Skip to content

Commit 6833e1f

Browse files
committed
Remove dart3-compatible search box.
1 parent f1f5d99 commit 6833e1f

File tree

5 files changed

+1
-43
lines changed

5 files changed

+1
-43
lines changed

app/lib/frontend/templates/views/pkg/index.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,6 @@ d.Node _searchFormContainer({
149149
searchForm: searchForm,
150150
title: 'Show only packages with screenshots.',
151151
),
152-
_tagBasedCheckbox(
153-
tagPrefix: 'is',
154-
tagValue: 'dart3-compatible',
155-
label: 'Dart 3 compatible',
156-
searchForm: searchForm,
157-
title: 'Show only packages compatible with Dart 3.',
158-
),
159152
_tagBasedCheckbox(
160153
tagPrefix: 'is',
161154
tagValue: 'plugin',

app/test/frontend/golden/pkg_index_page.html

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -353,23 +353,6 @@ <h3 class="search-form-section-header foldable-button">
353353
</label>
354354
</div>
355355
</div>
356-
<div class="search-form-linked-checkbox" title="Show only packages compatible with Dart 3.">
357-
<div class="mdc-form-field">
358-
<div class="mdc-checkbox">
359-
<input id="search-form-checkbox-is-dart3-compatible" class="mdc-checkbox__native-control" type="checkbox"/>
360-
<div class="mdc-checkbox__background">
361-
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
362-
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59"/>
363-
</svg>
364-
<div class="mdc-checkbox__mixedmark"></div>
365-
</div>
366-
<div class="mdc-checkbox__ripple"></div>
367-
</div>
368-
<label for="search-form-checkbox-is-dart3-compatible">
369-
<a href="/packages?q=sdk%3Adart+is%3Adart3-compatible" rel="nofollow" data-action="filter-is-dart3-compatible" data-tag="is:dart3-compatible">Dart 3 compatible</a>
370-
</label>
371-
</div>
372-
</div>
373356
<div class="search-form-linked-checkbox" title="Show only Flutter plugins.">
374357
<div class="mdc-form-field">
375358
<div class="mdc-checkbox">

app/test/frontend/golden/search_page.html

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -354,23 +354,6 @@ <h3 class="search-form-section-header foldable-button">
354354
</label>
355355
</div>
356356
</div>
357-
<div class="search-form-linked-checkbox" title="Show only packages compatible with Dart 3.">
358-
<div class="mdc-form-field">
359-
<div class="mdc-checkbox">
360-
<input id="search-form-checkbox-is-dart3-compatible" class="mdc-checkbox__native-control" type="checkbox"/>
361-
<div class="mdc-checkbox__background">
362-
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
363-
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59"/>
364-
</svg>
365-
<div class="mdc-checkbox__mixedmark"></div>
366-
</div>
367-
<div class="mdc-checkbox__ripple"></div>
368-
</div>
369-
<label for="search-form-checkbox-is-dart3-compatible">
370-
<a href="/packages?q=is%3Adart3-compatible+foobar&amp;sort=top" rel="nofollow" data-action="filter-is-dart3-compatible" data-tag="is:dart3-compatible">Dart 3 compatible</a>
371-
</label>
372-
</div>
373-
</div>
374357
<div class="search-form-linked-checkbox" title="Show only Flutter plugins.">
375358
<div class="mdc-form-field">
376359
<div class="mdc-checkbox">

pkg/_pub_shared/lib/search/search_form.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,6 @@ class SearchForm {
442442
parsedQuery.tagsPredicate.hasTag(PackageTags.isFlutterFavorite) ||
443443
parsedQuery.tagsPredicate.hasTag(PackageTags.showUnlisted) ||
444444
parsedQuery.tagsPredicate.hasTag(PackageVersionTags.hasScreenshot) ||
445-
parsedQuery.tagsPredicate.hasTag(PackageVersionTags.isDart3Compatible) ||
446445
parsedQuery.tagsPredicate.hasTag(PackageVersionTags.isPlugin) ||
447446
parsedQuery.tagsPredicate.hasTag(PackageVersionTags.isWasmReady);
448447

pkg/pub_integration/test/search_update_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ void main() {
222222
expect(page.url, '$origin/packages?q=platform%3Aandroid+pkg');
223223
}
224224

225-
await toggleMore('is', 'dart3-compatible');
225+
await toggleMore('is', 'wasm-ready');
226226
await toggleMore('is', 'flutter-favorite');
227227
});
228228

0 commit comments

Comments
 (0)