Skip to content

Commit 6dcbfbf

Browse files
szakariasszakarias
committed
Enable download counts
1 parent b78e371 commit 6dcbfbf

File tree

7 files changed

+351
-345
lines changed

7 files changed

+351
-345
lines changed

‎app/lib/frontend/handlers/experimental.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ class ExperimentalFlags {
9595
bool get isDarkModeEnabled => isEnabled('dark');
9696
bool get isDarkModeDefault => isEnabled('dark-as-default');
9797

98-
bool get showDownloadCounts => isEnabled('download-counts');
9998
bool get showDownloadCountsVersionChart =>
10099
isEnabled('download-counts-version-chart');
100+
bool get showDownloadCounts => true;
101101

102102
String encodedAsCookie() => _enabled.join(':');
103103

‎app/test/frontend/golden/my_packages.html‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -212,12 +212,12 @@ <h3 class="packages-title">
212212
</div>
213213
<div class="packages-score-label">pub points</div>
214214
</div>
215-
<div class="packages-score packages-score-popularity">
216-
<div class="packages-score-value -has-value">
217-
<span class="packages-score-value-number">3</span>
218-
<span class="packages-score-value-sign">%</span>
215+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
216+
<div class="packages-score-value">
217+
<span class="packages-score-value-number">--</span>
218+
<span class="packages-score-value-sign"></span>
219219
</div>
220-
<div class="packages-score-label">popularity</div>
220+
<div class="packages-score-label">downloads</div>
221221
</div>
222222
</a>
223223
</div>
@@ -295,12 +295,12 @@ <h3 class="packages-title">
295295
</div>
296296
<div class="packages-score-label">pub points</div>
297297
</div>
298-
<div class="packages-score packages-score-popularity">
299-
<div class="packages-score-value -has-value">
300-
<span class="packages-score-value-number">12</span>
301-
<span class="packages-score-value-sign">%</span>
298+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
299+
<div class="packages-score-value">
300+
<span class="packages-score-value-number">--</span>
301+
<span class="packages-score-value-sign"></span>
302302
</div>
303-
<div class="packages-score-label">popularity</div>
303+
<div class="packages-score-label">downloads</div>
304304
</div>
305305
</a>
306306
</div>

‎app/test/frontend/golden/pkg_index_page.html‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ <h3 class="search-form-section-header foldable-button">
424424
<button class="sort-control-option" data-value="like">most likes</button>
425425
<button class="sort-control-option" data-value="points">most pub points</button>
426426
<button class="sort-control-option" data-value="popularity">popularity</button>
427+
<button class="sort-control-option" data-value="downloads">downloads</button>
427428
</div>
428429
</div>
429430
</div>
@@ -479,12 +480,12 @@ <h3 class="packages-title">
479480
</div>
480481
<div class="packages-score-label">pub points</div>
481482
</div>
482-
<div class="packages-score packages-score-popularity">
483-
<div class="packages-score-value -has-value">
484-
<span class="packages-score-value-number">3</span>
485-
<span class="packages-score-value-sign">%</span>
483+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
484+
<div class="packages-score-value">
485+
<span class="packages-score-value-number">--</span>
486+
<span class="packages-score-value-sign"></span>
486487
</div>
487-
<div class="packages-score-label">popularity</div>
488+
<div class="packages-score-label">downloads</div>
488489
</div>
489490
</a>
490491
</div>
@@ -562,12 +563,12 @@ <h3 class="packages-title">
562563
</div>
563564
<div class="packages-score-label">pub points</div>
564565
</div>
565-
<div class="packages-score packages-score-popularity">
566-
<div class="packages-score-value -has-value">
567-
<span class="packages-score-value-number">43</span>
568-
<span class="packages-score-value-sign">%</span>
566+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
567+
<div class="packages-score-value">
568+
<span class="packages-score-value-number">--</span>
569+
<span class="packages-score-value-sign"></span>
569570
</div>
570-
<div class="packages-score-label">popularity</div>
571+
<div class="packages-score-label">downloads</div>
571572
</div>
572573
</a>
573574
</div>

‎app/test/frontend/golden/publisher_packages_page.html‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ <h1 class="title">example.com</h1>
178178
<button class="sort-control-option" data-value="like">most likes</button>
179179
<button class="sort-control-option" data-value="points">most pub points</button>
180180
<button class="sort-control-option" data-value="popularity">popularity</button>
181+
<button class="sort-control-option" data-value="downloads">downloads</button>
181182
</div>
182183
</div>
183184
</div>
@@ -214,12 +215,12 @@ <h3 class="packages-title">
214215
</div>
215216
<div class="packages-score-label">pub points</div>
216217
</div>
217-
<div class="packages-score packages-score-popularity">
218-
<div class="packages-score-value -has-value">
219-
<span class="packages-score-value-number">12</span>
220-
<span class="packages-score-value-sign">%</span>
218+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
219+
<div class="packages-score-value">
220+
<span class="packages-score-value-number">--</span>
221+
<span class="packages-score-value-sign"></span>
221222
</div>
222-
<div class="packages-score-label">popularity</div>
223+
<div class="packages-score-label">downloads</div>
223224
</div>
224225
</a>
225226
</div>
@@ -295,12 +296,12 @@ <h3 class="packages-title">
295296
</div>
296297
<div class="packages-score-label">pub points</div>
297298
</div>
298-
<div class="packages-score packages-score-popularity">
299-
<div class="packages-score-value -has-value">
300-
<span class="packages-score-value-number">43</span>
301-
<span class="packages-score-value-sign">%</span>
299+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
300+
<div class="packages-score-value">
301+
<span class="packages-score-value-number">--</span>
302+
<span class="packages-score-value-sign"></span>
302303
</div>
303-
<div class="packages-score-label">popularity</div>
304+
<div class="packages-score-label">downloads</div>
304305
</div>
305306
</a>
306307
</div>

‎app/test/frontend/golden/publisher_unlisted_packages_page.html‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ <h1 class="title">example.com</h1>
178178
<button class="sort-control-option" data-value="like">most likes</button>
179179
<button class="sort-control-option" data-value="points">most pub points</button>
180180
<button class="sort-control-option" data-value="popularity">popularity</button>
181+
<button class="sort-control-option" data-value="downloads">downloads</button>
181182
</div>
182183
</div>
183184
</div>
@@ -220,12 +221,12 @@ <h3 class="packages-title">
220221
</div>
221222
<div class="packages-score-label">pub points</div>
222223
</div>
223-
<div class="packages-score packages-score-popularity">
224-
<div class="packages-score-value -has-value">
225-
<span class="packages-score-value-number">12</span>
226-
<span class="packages-score-value-sign">%</span>
224+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
225+
<div class="packages-score-value">
226+
<span class="packages-score-value-number">--</span>
227+
<span class="packages-score-value-sign"></span>
227228
</div>
228-
<div class="packages-score-label">popularity</div>
229+
<div class="packages-score-label">downloads</div>
229230
</div>
230231
</a>
231232
</div>
@@ -301,12 +302,12 @@ <h3 class="packages-title">
301302
</div>
302303
<div class="packages-score-label">pub points</div>
303304
</div>
304-
<div class="packages-score packages-score-popularity">
305-
<div class="packages-score-value -has-value">
306-
<span class="packages-score-value-number">43</span>
307-
<span class="packages-score-value-sign">%</span>
305+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
306+
<div class="packages-score-value">
307+
<span class="packages-score-value-number">--</span>
308+
<span class="packages-score-value-sign"></span>
308309
</div>
309-
<div class="packages-score-label">popularity</div>
310+
<div class="packages-score-label">downloads</div>
310311
</div>
311312
</a>
312313
</div>

‎app/test/frontend/golden/search_page.html‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -425,6 +425,7 @@ <h3 class="search-form-section-header foldable-button">
425425
<button class="sort-control-option" data-value="like">most likes</button>
426426
<button class="sort-control-option" data-value="points">most pub points</button>
427427
<button class="sort-control-option" data-value="popularity">popularity</button>
428+
<button class="sort-control-option" data-value="downloads">downloads</button>
428429
</div>
429430
</div>
430431
</div>
@@ -461,12 +462,12 @@ <h3 class="packages-title">
461462
</div>
462463
<div class="packages-score-label">pub points</div>
463464
</div>
464-
<div class="packages-score packages-score-popularity">
465-
<div class="packages-score-value -has-value">
466-
<span class="packages-score-value-number">3</span>
467-
<span class="packages-score-value-sign">%</span>
465+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
466+
<div class="packages-score-value">
467+
<span class="packages-score-value-number">--</span>
468+
<span class="packages-score-value-sign"></span>
468469
</div>
469-
<div class="packages-score-label">popularity</div>
470+
<div class="packages-score-label">downloads</div>
470471
</div>
471472
</a>
472473
</div>
@@ -555,12 +556,12 @@ <h3 class="packages-title">
555556
</div>
556557
<div class="packages-score-label">pub points</div>
557558
</div>
558-
<div class="packages-score packages-score-popularity">
559-
<div class="packages-score-value -has-value">
560-
<span class="packages-score-value-number">43</span>
561-
<span class="packages-score-value-sign">%</span>
559+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
560+
<div class="packages-score-value">
561+
<span class="packages-score-value-number">--</span>
562+
<span class="packages-score-value-sign"></span>
562563
</div>
563-
<div class="packages-score-label">popularity</div>
564+
<div class="packages-score-label">downloads</div>
564565
</div>
565566
</a>
566567
</div>

0 commit comments

Comments
 (0)