cleanup

Author: isoos

app/lib/frontend/handlers/custom_api.dart

@@ -452,10 +452,7 @@ const _commonLicenses = [
 /// Handles requests for /api/search
 Future<shelf.Response> apiSearchHandler(shelf.Request request) async {
   final searchForm = SearchForm.parse(request.requestedUri.queryParameters);
-  final sr = await searchClient.search(
-    searchForm.toServiceQuery(),
-    sourceIp: request.sourceIp,
-  );
+  final sr = await searchClient.search(searchForm.toServiceQuery());
   final packages = sr.packageHits.map((ps) => {'package': ps.package}).toList();
   final hasNextPage = sr.totalCount > searchForm.pageSize! + searchForm.offset;
   final result = <String, dynamic>{

app/lib/package/search_adapter.dart

@@ -62,10 +62,7 @@ class SearchAdapter {
   ) async {
     PackageSearchResult? result;
     try {
-      result = await searchClient.search(
-        searchForm.toServiceQuery(),
-        sourceIp: sourceIp,
-      );
+      result = await searchClient.search(searchForm.toServiceQuery());
     } on RateLimitException {
       rethrow;
     } catch (e, st) {

app/lib/search/backend.dart

@@ -495,8 +495,6 @@ class SearchBackend {
       // Do not cache response at the search client level, as we'll be caching
       // it in a processed form much longer.
       skipCache: true,
-      // Do not apply rate limit here.
-      sourceIp: null,
     );
     return {'packages': rs.packageHits.map((p) => p.package).toList()};
   }

app/lib/search/search_client.dart

@@ -39,7 +39,6 @@ class SearchClient {
   /// Calls the search service (or uses cache) to serve the [query].
   Future<PackageSearchResult> search(
     ServiceSearchQuery query, {
-    required String? sourceIp,
     bool skipCache = false,
   }) async {
     // check validity first