Skip to content

Commit 735c45c

Browse files
authored
Decrease aborted task log level + tag log message. (#9046)
1 parent 2faf5f1 commit 735c45c

File tree

1 file changed

+11
-19
lines changed

1 file changed

+11
-19
lines changed

pkg/pub_worker/lib/src/analyze.dart

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -73,28 +73,20 @@ Future<void> analyze(Payload payload) async {
7373
client: client.withAuthorization(() => p.token),
7474
);
7575

76-
void warnTaskAborted(Exception e, StackTrace st) {
77-
_log.warning(
78-
'Task was aborted when uploading ${payload.package} / ${p.version}',
79-
e,
80-
st,
81-
);
76+
void infoTaskAborted(Exception e, StackTrace st) {
77+
final msg =
78+
'[pub-task-aborted] Task was aborted when uploading ${payload.package} / ${p.version}';
79+
_log.info(msg, e, st);
8280
}
8381

8482
void warnTaskError(Exception e, StackTrace st) {
85-
_log.warning(
86-
'Failed to process ${payload.package} / ${p.version}',
87-
e,
88-
st,
89-
);
83+
final msg = 'Failed to process ${payload.package} / ${p.version}';
84+
_log.warning(msg, e, st);
9085
}
9186

9287
void shoutTaskError(Object e, StackTrace st) {
93-
_log.shout(
94-
'Failed to process ${payload.package} / ${p.version}',
95-
e,
96-
st,
97-
);
88+
final msg = 'Failed to process ${payload.package} / ${p.version}';
89+
_log.shout(msg, e, st);
9890
}
9991

10092
try {
@@ -123,23 +115,23 @@ Future<void> analyze(Payload payload) async {
123115
);
124116
}
125117
} on TaskAbortedException catch (e, st) {
126-
warnTaskAborted(e, st);
118+
infoTaskAborted(e, st);
127119
} on RequestException catch (e, st) {
128120
late final map = e.bodyAsJson();
129121
late final error = map['error'];
130122
late final code = map['code'] ?? (error is Map ? error['code'] : null);
131123
if (e.status >= 500) {
132124
warnTaskError(e, st);
133125
} else if (e.status == 400 && code is String && code == 'TaskAborted') {
134-
warnTaskAborted(e, st);
126+
infoTaskAborted(e, st);
135127
} else {
136128
shoutTaskError(e, st);
137129
}
138130
} on ApiResponseException catch (e, st) {
139131
if (e.status >= 500) {
140132
warnTaskError(e, st);
141133
} else if (e.status == 400 && e.code == 'TaskAborted') {
142-
warnTaskAborted(e, st);
134+
infoTaskAborted(e, st);
143135
} else {
144136
shoutTaskError(e, st);
145137
}

0 commit comments

Comments
 (0)