Make moderation lenient wrt. moderationcase status

Author: sigurdm

app/lib/admin/actions/moderate_package.dart

@@ -52,10 +52,7 @@ Note: the action may take a longer time to complete as the public archive bucket
     final note = options['note'];
 
     final refCase =
-        await adminBackend.loadAndVerifyModerationCaseForAdminAction(
-      caseId,
-      status: ModerationStatus.pending,
-    );
+        await adminBackend.loadAndVerifyModerationCaseForAdminAction(caseId);
 
     final p = await packageBackend.lookupPackage(package!);
     if (p == null) {

app/lib/admin/actions/moderate_package_versions.dart

@@ -62,10 +62,7 @@ Set the moderated flag on a package version (updating the flag and the timestamp
     final note = options['note'];
 
     final refCase =
-        await adminBackend.loadAndVerifyModerationCaseForAdminAction(
-      caseId,
-      status: ModerationStatus.pending,
-    );
+        await adminBackend.loadAndVerifyModerationCaseForAdminAction(caseId);
 
     final p = await packageBackend.lookupPackage(package!);
     if (p == null) {

app/lib/admin/actions/moderate_publisher.dart

@@ -54,10 +54,7 @@ can't be updated, administrators must not be able to update publisher options.
     final note = options['note'];
 
     final refCase =
-        await adminBackend.loadAndVerifyModerationCaseForAdminAction(
-      caseId,
-      status: ModerationStatus.pending,
-    );
+        await adminBackend.loadAndVerifyModerationCaseForAdminAction(caseId);
 
     Publisher? publisher2;
     if (valueToSet != null) {

app/lib/admin/actions/moderate_user.dart

@@ -49,10 +49,7 @@ The active web sessions of the user will be expired.
     final note = options['note'];
 
     final refCase =
-        await adminBackend.loadAndVerifyModerationCaseForAdminAction(
-      caseId,
-      status: null,
-    );
+        await adminBackend.loadAndVerifyModerationCaseForAdminAction(caseId);
 
     User? user;
     if (looksLikeUserId(userIdOrEmail!)) {

app/lib/admin/backend.dart

@@ -754,9 +754,8 @@ class AdminBackend {
   ///
   /// Throws exceptions otherwise.
   Future<ModerationCase?> loadAndVerifyModerationCaseForAdminAction(
-    String? caseId, {
-    required String? status,
-  }) async {
+    String? caseId,
+  ) async {
     InvalidInputException.check(
       caseId != null && caseId.isNotEmpty,
       'case must be given',
@@ -769,10 +768,6 @@ class AdminBackend {
     if (refCase == null) {
       throw NotFoundException.resource(caseId);
     }
-    if (status != null && refCase.status != status) {
-      throw InvalidInputException(
-          'ModerationCase.status ("${refCase.status}") != "$status".');
-    }
     return refCase;
   }