Skip to content

Commit 75201c2

Browse files
szakariasszakarias
authored
Remove <p> tag from weekly sparkline (#8392)
1 parent 0124843 commit 75201c2

18 files changed

+562
-501
lines changed

‎app/lib/frontend/templates/views/pkg/info_box.dart‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ d.Node packageInfoBoxNode({
8585
_publisher(package.publisherId),
8686
if (data.weeklyDownloadCounts != null &&
8787
requestContext.experimentalFlags.showDownloadCounts)
88-
_block('Weekly Downloads', _downloadsChart(data.weeklyDownloadCounts!)),
88+
_downloadsChart(data.weeklyDownloadCounts!),
8989
_metadata(
9090
description: version.pubspec!.description,
9191
metaLinks: metaLinks,
@@ -120,7 +120,11 @@ d.Node _downloadsChart(WeeklyDownloadCounts wdc) {
120120
'data-weekly-sparkline-points':
121121
_encodeForWeeklySparkline(wdc.weeklyDownloads, wdc.newestDate),
122122
});
123-
return container;
123+
124+
return d.fragment([
125+
d.h3(classes: ['title'], text: 'Weekly Downloads'),
126+
container,
127+
]);
124128
}
125129

126130
String _encodeForWeeklySparkline(List<int> downloads, DateTime newestDate) {

‎app/test/frontend/golden/pkg_activity_log_page.html‎

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -370,18 +370,20 @@ <h3 class="detail-lead-title">Metadata</h3>
370370
</div>
371371
<div class="packages-score-label">points</div>
372372
</div>
373-
<div class="packages-score packages-score-popularity">
374-
<div class="packages-score-value -has-value">
375-
<span class="packages-score-value-number">3</span>
376-
<span class="packages-score-value-sign">%</span>
373+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
374+
<div class="packages-score-value">
375+
<span class="packages-score-value-number">--</span>
376+
<span class="packages-score-value-sign"></span>
377377
</div>
378-
<div class="packages-score-label">popularity</div>
378+
<div class="packages-score-label">downloads</div>
379379
</div>
380380
</a>
381381
<h3 class="title">Publisher</h3>
382382
<p>
383383
<span>unverified uploader</span>
384384
</p>
385+
<h3 class="title">Weekly Downloads</h3>
386+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
385387
<h3 class="title pkg-infobox-metadata">Metadata</h3>
386388
<p>oxygen is awesome</p>
387389
<p>
@@ -446,18 +448,20 @@ <h3 class="detail-metadata-title">
446448
</div>
447449
<div class="packages-score-label">points</div>
448450
</div>
449-
<div class="packages-score packages-score-popularity">
450-
<div class="packages-score-value -has-value">
451-
<span class="packages-score-value-number">3</span>
452-
<span class="packages-score-value-sign">%</span>
451+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
452+
<div class="packages-score-value">
453+
<span class="packages-score-value-number">--</span>
454+
<span class="packages-score-value-sign"></span>
453455
</div>
454-
<div class="packages-score-label">popularity</div>
456+
<div class="packages-score-label">downloads</div>
455457
</div>
456458
</a>
457459
<h3 class="title">Publisher</h3>
458460
<p>
459461
<span>unverified uploader</span>
460462
</p>
463+
<h3 class="title">Weekly Downloads</h3>
464+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
461465
<h3 class="title pkg-infobox-metadata">Metadata</h3>
462466
<p>oxygen is awesome</p>
463467
<p>

‎app/test/frontend/golden/pkg_admin_page.html‎

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -655,18 +655,20 @@ <h3>Restore retracted package version</h3>
655655
</div>
656656
<div class="packages-score-label">points</div>
657657
</div>
658-
<div class="packages-score packages-score-popularity">
659-
<div class="packages-score-value -has-value">
660-
<span class="packages-score-value-number">3</span>
661-
<span class="packages-score-value-sign">%</span>
658+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
659+
<div class="packages-score-value">
660+
<span class="packages-score-value-number">--</span>
661+
<span class="packages-score-value-sign"></span>
662662
</div>
663-
<div class="packages-score-label">popularity</div>
663+
<div class="packages-score-label">downloads</div>
664664
</div>
665665
</a>
666666
<h3 class="title">Publisher</h3>
667667
<p>
668668
<span>unverified uploader</span>
669669
</p>
670+
<h3 class="title">Weekly Downloads</h3>
671+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
670672
<h3 class="title pkg-infobox-metadata">Metadata</h3>
671673
<p>oxygen is awesome</p>
672674
<p>
@@ -731,18 +733,20 @@ <h3 class="detail-metadata-title">
731733
</div>
732734
<div class="packages-score-label">points</div>
733735
</div>
734-
<div class="packages-score packages-score-popularity">
735-
<div class="packages-score-value -has-value">
736-
<span class="packages-score-value-number">3</span>
737-
<span class="packages-score-value-sign">%</span>
736+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
737+
<div class="packages-score-value">
738+
<span class="packages-score-value-number">--</span>
739+
<span class="packages-score-value-sign"></span>
738740
</div>
739-
<div class="packages-score-label">popularity</div>
741+
<div class="packages-score-label">downloads</div>
740742
</div>
741743
</a>
742744
<h3 class="title">Publisher</h3>
743745
<p>
744746
<span>unverified uploader</span>
745747
</p>
748+
<h3 class="title">Weekly Downloads</h3>
749+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
746750
<h3 class="title pkg-infobox-metadata">Metadata</h3>
747751
<p>oxygen is awesome</p>
748752
<p>

‎app/test/frontend/golden/pkg_changelog_page.html‎

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -240,18 +240,20 @@ <h2 class="changelog-version hash-header" id="120">
240240
</div>
241241
<div class="packages-score-label">points</div>
242242
</div>
243-
<div class="packages-score packages-score-popularity">
244-
<div class="packages-score-value -has-value">
245-
<span class="packages-score-value-number">3</span>
246-
<span class="packages-score-value-sign">%</span>
243+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
244+
<div class="packages-score-value">
245+
<span class="packages-score-value-number">--</span>
246+
<span class="packages-score-value-sign"></span>
247247
</div>
248-
<div class="packages-score-label">popularity</div>
248+
<div class="packages-score-label">downloads</div>
249249
</div>
250250
</a>
251251
<h3 class="title">Publisher</h3>
252252
<p>
253253
<span>unverified uploader</span>
254254
</p>
255+
<h3 class="title">Weekly Downloads</h3>
256+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
255257
<h3 class="title pkg-infobox-metadata">Metadata</h3>
256258
<p>oxygen is awesome</p>
257259
<p>
@@ -317,18 +319,20 @@ <h3 class="detail-metadata-title">
317319
</div>
318320
<div class="packages-score-label">points</div>
319321
</div>
320-
<div class="packages-score packages-score-popularity">
321-
<div class="packages-score-value -has-value">
322-
<span class="packages-score-value-number">3</span>
323-
<span class="packages-score-value-sign">%</span>
322+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
323+
<div class="packages-score-value">
324+
<span class="packages-score-value-number">--</span>
325+
<span class="packages-score-value-sign"></span>
324326
</div>
325-
<div class="packages-score-label">popularity</div>
327+
<div class="packages-score-label">downloads</div>
326328
</div>
327329
</a>
328330
<h3 class="title">Publisher</h3>
329331
<p>
330332
<span>unverified uploader</span>
331333
</p>
334+
<h3 class="title">Weekly Downloads</h3>
335+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
332336
<h3 class="title pkg-infobox-metadata">Metadata</h3>
333337
<p>oxygen is awesome</p>
334338
<p>

‎app/test/frontend/golden/pkg_example_page.html‎

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -237,18 +237,20 @@ <h3 class="detail-lead-title">Metadata</h3>
237237
</div>
238238
<div class="packages-score-label">points</div>
239239
</div>
240-
<div class="packages-score packages-score-popularity">
241-
<div class="packages-score-value -has-value">
242-
<span class="packages-score-value-number">3</span>
243-
<span class="packages-score-value-sign">%</span>
240+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
241+
<div class="packages-score-value">
242+
<span class="packages-score-value-number">--</span>
243+
<span class="packages-score-value-sign"></span>
244244
</div>
245-
<div class="packages-score-label">popularity</div>
245+
<div class="packages-score-label">downloads</div>
246246
</div>
247247
</a>
248248
<h3 class="title">Publisher</h3>
249249
<p>
250250
<span>unverified uploader</span>
251251
</p>
252+
<h3 class="title">Weekly Downloads</h3>
253+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
252254
<h3 class="title pkg-infobox-metadata">Metadata</h3>
253255
<p>oxygen is awesome</p>
254256
<p>
@@ -314,18 +316,20 @@ <h3 class="detail-metadata-title">
314316
</div>
315317
<div class="packages-score-label">points</div>
316318
</div>
317-
<div class="packages-score packages-score-popularity">
318-
<div class="packages-score-value -has-value">
319-
<span class="packages-score-value-number">3</span>
320-
<span class="packages-score-value-sign">%</span>
319+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
320+
<div class="packages-score-value">
321+
<span class="packages-score-value-number">--</span>
322+
<span class="packages-score-value-sign"></span>
321323
</div>
322-
<div class="packages-score-label">popularity</div>
324+
<div class="packages-score-label">downloads</div>
323325
</div>
324326
</a>
325327
<h3 class="title">Publisher</h3>
326328
<p>
327329
<span>unverified uploader</span>
328330
</p>
331+
<h3 class="title">Weekly Downloads</h3>
332+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
329333
<h3 class="title pkg-infobox-metadata">Metadata</h3>
330334
<p>oxygen is awesome</p>
331335
<p>

‎app/test/frontend/golden/pkg_install_page.html‎

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -263,18 +263,20 @@ <h3>Import it</h3>
263263
</div>
264264
<div class="packages-score-label">points</div>
265265
</div>
266-
<div class="packages-score packages-score-popularity">
267-
<div class="packages-score-value -has-value">
268-
<span class="packages-score-value-number">3</span>
269-
<span class="packages-score-value-sign">%</span>
266+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
267+
<div class="packages-score-value">
268+
<span class="packages-score-value-number">--</span>
269+
<span class="packages-score-value-sign"></span>
270270
</div>
271-
<div class="packages-score-label">popularity</div>
271+
<div class="packages-score-label">downloads</div>
272272
</div>
273273
</a>
274274
<h3 class="title">Publisher</h3>
275275
<p>
276276
<span>unverified uploader</span>
277277
</p>
278+
<h3 class="title">Weekly Downloads</h3>
279+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
278280
<h3 class="title pkg-infobox-metadata">Metadata</h3>
279281
<p>oxygen is awesome</p>
280282
<p>
@@ -340,18 +342,20 @@ <h3 class="detail-metadata-title">
340342
</div>
341343
<div class="packages-score-label">points</div>
342344
</div>
343-
<div class="packages-score packages-score-popularity">
344-
<div class="packages-score-value -has-value">
345-
<span class="packages-score-value-number">3</span>
346-
<span class="packages-score-value-sign">%</span>
345+
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
346+
<div class="packages-score-value">
347+
<span class="packages-score-value-number">--</span>
348+
<span class="packages-score-value-sign"></span>
347349
</div>
348-
<div class="packages-score-label">popularity</div>
350+
<div class="packages-score-label">downloads</div>
349351
</div>
350352
</a>
351353
<h3 class="title">Publisher</h3>
352354
<p>
353355
<span>unverified uploader</span>
354356
</p>
357+
<h3 class="title">Weekly Downloads</h3>
358+
<div id="-weekly-downloads-sparkline" class="weekly-downloads-sparkline" data-widget="weekly-sparkline" data-weekly-sparkline-points="gIRXZwMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="></div>
355359
<h3 class="title pkg-infobox-metadata">Metadata</h3>
356360
<p>oxygen is awesome</p>
357361
<p>

0 commit comments

Comments
 (0)