Skip to content

Commit 7ed8142

Browse files
committed
Use :root instead of .light-theme
1 parent 1976c6d commit 7ed8142

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/web_css/lib/src/_variables.scss

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
// - `[role]` may be the `background`, `text`, `border`, ... (multiple parts are separated by `_`)
1616
// - `[property]` may be `color`, `opacity` for specific values, or a `value` for multi-part properties.
1717

18+
/// Variables that are not specific to the light or dark theme.
1819
:root {
1920
--pub-default-headline-font_family: "Google Sans Display", "Google Sans", "Roboto", sans-serif;
2021
--pub-default-text-font_family: "Google Sans Text", "Google Sans", "Roboto", sans-serif;
@@ -74,7 +75,8 @@
7475
--mdc-typography-font-family: var(--pub-default-text-font_family);
7576
}
7677

77-
.light-theme {
78+
/// Variables that are specific to the light theme.
79+
:root {
7880
@include dash_variables.light-theme;
7981

8082
--pub-color-snowWhite: #fafafa; // slight deviation from official snow-white (fffafa)
@@ -119,12 +121,15 @@
119121
--pub-tag_simplebadge-text-color: #444444;
120122
--pub-tag_sdkbadge-separator-color: rgba(25, 103, 210, 0.5); // #1967d2 + 0.5 opacity;
121123
--pub-tag_sdkbadge-text-color: #1967d2;
124+
}
122125

126+
.light-theme {
123127
.displayed-in-dark-theme {
124128
display: none !important;
125129
}
126130
}
127131

132+
/// Variables that are specific to the dark theme.
128133
.dark-theme {
129134
@include dash_variables.dark-theme;
130135

0 commit comments

Comments
 (0)