Skip to content

Commit 86dcd84

Browse files
authored
Fix inconsistency between package list and package page copy icon opacities (#8559)
1 parent 1b9b75b commit 86dcd84

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+55
-62
lines changed

app/lib/frontend/templates/views/pkg/package_list.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,8 @@ d.Node _item({
225225
classes: ['packages-header'],
226226
children: [
227227
d.h3(classes: [
228-
'packages-title'
228+
'packages-title',
229+
'pub-monochrome-icon-hoverable',
229230
], children: [
230231
d.a(href: url, text: name),
231232
if (copyIcon != null) copyIcon,

app/lib/frontend/templates/views/shared/detail/header.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,10 @@ d.Node detailHeaderNode({
111111
d.div(
112112
classes: ['detail-header-content-block'],
113113
children: [
114-
d.h1(classes: ['title'], child: titleNode),
114+
d.h1(
115+
classes: ['title', 'pub-monochrome-icon-hoverable'],
116+
child: titleNode,
117+
),
115118
d.div(classes: ['metadata'], child: metadataNode),
116119
if (tagsNode != null || likeCount != null)
117120
d.div(

app/test/frontend/golden/my_activity_log_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ <h3 class="foldable-button">
142142
<img class="detail-header-image" src="https://www.gravatar.com/avatar/92c525024f1911332fe1d0f7dd750977?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
143143
</div>
144144
<div class="detail-header-content-block">
145-
<h1 class="title">admin</h1>
145+
<h1 class="title pub-monochrome-icon-hoverable">admin</h1>
146146
<div class="metadata">
147147
148148
<p>

app/test/frontend/golden/my_liked_packages.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ <h3 class="foldable-button">
143143
<img class="detail-header-image" src="https://www.gravatar.com/avatar/f1983c9193966b63c29c141c02db9a34?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
144144
</div>
145145
<div class="detail-header-content-block">
146-
<h1 class="title">user</h1>
146+
<h1 class="title pub-monochrome-icon-hoverable">user</h1>
147147
<div class="metadata">
148148
149149
<p>

app/test/frontend/golden/my_packages.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ <h3 class="foldable-button">
142142
<img class="detail-header-image" src="https://www.gravatar.com/avatar/f1983c9193966b63c29c141c02db9a34?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
143143
</div>
144144
<div class="detail-header-content-block">
145-
<h1 class="title">user</h1>
145+
<h1 class="title pub-monochrome-icon-hoverable">user</h1>
146146
<div class="metadata">
147147
148148
<p>
@@ -183,7 +183,7 @@ <h1 class="title">user</h1>
183183
<div class="packages">
184184
<div class="packages-item">
185185
<div class="packages-header">
186-
<h3 class="packages-title">
186+
<h3 class="packages-title pub-monochrome-icon-hoverable">
187187
<a href="/packages/oxygen">oxygen</a>
188188
<span class="pkg-page-title-copy">
189189
<img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>
@@ -266,7 +266,7 @@ <h3 class="packages-title">
266266
</div>
267267
<div class="packages-item">
268268
<div class="packages-header">
269-
<h3 class="packages-title">
269+
<h3 class="packages-title pub-monochrome-icon-hoverable">
270270
<a href="/packages/neon">neon</a>
271271
<span class="pkg-page-title-copy">
272272
<img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;neon: ^1.0.0&quot; to clipboard" width="18" height="18" title="Copy &quot;neon: ^1.0.0&quot; to clipboard" data-copy-content="neon: ^1.0.0" data-ga-click-event="copy-package-version"/>

app/test/frontend/golden/my_publishers.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ <h3 class="foldable-button">
142142
<img class="detail-header-image" src="https://www.gravatar.com/avatar/f1983c9193966b63c29c141c02db9a34?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
143143
</div>
144144
<div class="detail-header-content-block">
145-
<h1 class="title">user</h1>
145+
<h1 class="title pub-monochrome-icon-hoverable">user</h1>
146146
<div class="metadata">
147147
148148
<p>

app/test/frontend/golden/pkg_activity_log_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ <h3 class="foldable-button">
141141
<div class="detail-container">
142142
<div class="detail-header-outer-block">
143143
<div class="detail-header-content-block">
144-
<h1 class="title">
144+
<h1 class="title pub-monochrome-icon-hoverable">
145145
oxygen 1.2.0
146146
<span class="pkg-page-title-copy">
147147
<img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

app/test/frontend/golden/pkg_admin_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ <h3 class="foldable-button">
141141
<div class="detail-container">
142142
<div class="detail-header-outer-block">
143143
<div class="detail-header-content-block">
144-
<h1 class="title">
144+
<h1 class="title pub-monochrome-icon-hoverable">
145145
oxygen 1.2.0
146146
<span class="pkg-page-title-copy">
147147
<img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

app/test/frontend/golden/pkg_changelog_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
115115
<div class="detail-container">
116116
<div class="detail-header-outer-block">
117117
<div class="detail-header-content-block">
118-
<h1 class="title">
118+
<h1 class="title pub-monochrome-icon-hoverable">
119119
oxygen 1.2.0
120120
<span class="pkg-page-title-copy">
121121
<img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

app/test/frontend/golden/pkg_example_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
115115
<div class="detail-container">
116116
<div class="detail-header-outer-block">
117117
<div class="detail-header-content-block">
118-
<h1 class="title">
118+
<h1 class="title pub-monochrome-icon-hoverable">
119119
oxygen 1.2.0
120120
<span class="pkg-page-title-copy">
121121
<img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

0 commit comments

Comments
 (0)