Update to use and analyze with 3.5 language version (#8041)

* Update to 3.5 language version

* Revert runtime SDK change

Author: parlough

.github/workflows/dart.yml

@@ -1,4 +1,4 @@
-# Created with package:mono_repo v6.6.1
+# Created with package:mono_repo v6.6.2
 name: Dart CI
 on:
   push:
@@ -36,7 +36,7 @@ jobs:
         name: Checkout repository
         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
       - name: mono_repo self validate
-        run: dart pub global activate mono_repo 6.6.1
+        run: dart pub global activate mono_repo 6.6.2
       - name: mono_repo self validate
         run: dart pub global run mono_repo generate --validate
   job_002:

analysis_options.yaml

@@ -9,7 +9,6 @@ analyzer:
 linter:
   rules:
   - always_declare_return_types
-  - always_require_non_null_named_parameters
   - annotate_overrides
   - avoid_empty_else
   - avoid_init_to_null
@@ -50,7 +49,6 @@ linter:
   - prefer_collection_literals
   - prefer_conditional_assignment
   - prefer_contains
-  - prefer_equal_for_default_values
   - prefer_final_fields
   - prefer_final_locals
   - prefer_for_elements_to_map_fromIterable

app/lib/fake/backend/fake_email_sender.dart

@@ -36,7 +36,7 @@ class FakeEmailSender implements EmailSender {
     sentMessages.add(message);
     if (_outputDir != null) {
       final uuid = message.localMessageId ?? Ulid().toCanonical();
-      final file = File(p.join(_outputDir!, '$uuid.json'));
+      final file = File(p.join(_outputDir, '$uuid.json'));
       await file.parent.create(recursive: true);
       await file.writeAsString(json.encode(message.toJson()));
     }

app/lib/frontend/dom/dom.dart

@@ -1036,19 +1036,18 @@ class _StringElement extends _StringNode {
   final Map<String, String>? _attributes;
   final Object? _children;
 
-  _StringElement(this._tag, this._attributes, this._children) {
-    assert(_children == null ||
-        _children is _StringNode ||
-        (_children is Iterable<Node> &&
-            (_children as Iterable<Node>).every((c) => c is _StringNode)));
-  }
+  _StringElement(this._tag, this._attributes, this._children)
+      : assert(_children == null ||
+            _children is _StringNode ||
+            (_children is Iterable<Node> &&
+                (_children).every((c) => c is _StringNode)));
 
   @override
   void writeHtml(StringSink sink) {
     sink.write('<');
     sink.write(_tag);
     if (_attributes != null) {
-      for (final e in _attributes!.entries) {
+      for (final e in _attributes.entries) {
         sink.write(' ');
         sink.write(e.key);
         sink.write('="');

app/lib/package/model_properties.dart

@@ -121,7 +121,7 @@ class Pubspec {
     return (minDartVersion != null &&
             minDartVersion.value.compareTo(dartSdkVersion) > 0) ||
         (_minFlutterSdkVersion != null &&
-            _minFlutterSdkVersion!.value.compareTo(flutterSdkVersion) > 0);
+            _minFlutterSdkVersion.value.compareTo(flutterSdkVersion) > 0);
   }
 
   /// True if either the Dart or the Flutter SDK constraint is higher than the
@@ -144,8 +144,8 @@ class Pubspec {
   late final _dartSdkConstraint = _inner.environment?['sdk'];
   late final _flutterSdkConstraint = _inner.environment?['flutter'];
   late final _hasDartSdkConstraint = _dartSdkConstraint != null &&
-      !_dartSdkConstraint!.isAny &&
-      !_dartSdkConstraint!.isEmpty;
+      !_dartSdkConstraint.isAny &&
+      !_dartSdkConstraint.isEmpty;
 
   SdkConstraintStatus get _sdkConstraintStatus =>
       SdkConstraintStatus.fromSdkVersion(_dartSdkConstraint, name);

app/lib/package/name_tracker.dart

@@ -158,7 +158,7 @@ class NameTracker {
     await for (final p in _db!.query<Package>().run()) {
       data.add(TrackedPackage.fromPackage(p));
     }
-    await for (final p in _db!.query<ModeratedPackage>().run()) {
+    await for (final p in _db.query<ModeratedPackage>().run()) {
       data.addModeratedName(p.name!);
     }
     _data = data;
@@ -185,7 +185,7 @@ class NameTracker {
         _data.add(TrackedPackage.fromPackage(p));
       }
 
-      final moderatedPkgQuery = _db!.query<ModeratedPackage>()
+      final moderatedPkgQuery = _db.query<ModeratedPackage>()
         ..order('moderated')
         ..filter('moderated >', ts);
 

app/lib/tool/utils/http.dart

@@ -53,7 +53,7 @@ class _AuthenticatedClient extends http.BaseClient {
     }
     final currentCookies = request.headers['cookie'];
     final providedCookies =
-        _cookieProvider == null ? null : await _cookieProvider!();
+        _cookieProvider == null ? null : await _cookieProvider();
 
     final sessionId = await _sessionIdProvider();
     request.headers['cookie'] = [

app/pubspec.lock

@@ -937,4 +937,4 @@ packages:
     source: hosted
     version: "2.2.1"
 sdks:
-  dart: ">=3.5.0-259.0.dev <4.0.0"
+  dart: ">=3.5.0 <4.0.0"

app/pubspec.yaml

@@ -1,7 +1,7 @@
 name: pub_dev
 description: The pub.dartlang.org website.
 environment:
-  sdk: '^3.0.0'
+  sdk: ^3.5.0
 dependencies:
   _popularity:
     path: ../pkg/_popularity

pkg/_popularity/pubspec.lock

@@ -559,4 +559,4 @@ packages:
     source: hosted
     version: "3.1.2"
 sdks:
-  dart: ">=3.5.0-259.0.dev <4.0.0"
+  dart: ">=3.5.0 <4.0.0"