Merge branch 'master' into misc/web-app-api-cleanup

Author: parlough

analysis_options.yaml

@@ -8,72 +8,77 @@ analyzer:
 # https://dart.dev/lints
 linter:
   rules:
-  - always_declare_return_types
-  - annotate_overrides
-  - avoid_empty_else
-  - avoid_init_to_null
-  - avoid_null_checks_in_equality_operators
-  - avoid_relative_lib_imports
-  - avoid_return_types_on_setters
-  - avoid_shadowing_type_parameters
-  - avoid_types_as_parameter_names
-  - await_only_futures
-  - camel_case_extensions
-  - camel_case_types
-  - cancel_subscriptions
-  - close_sinks
-  - collection_methods_unrelated_type
-  - comment_references
-  - constant_identifier_names
-  - control_flow_in_finally
-  - curly_braces_in_flow_control_structures
-  - directives_ordering
-  - empty_catches
-  - empty_constructor_bodies
-  - empty_statements
-  - hash_and_equals
-  - implementation_imports
-  - library_names
-  - library_prefixes
-  - literal_only_boolean_expressions
-  - no_duplicate_case_values
-  - non_constant_identifier_names
-  - null_closures
-  #- omit_local_variable_types
-  - one_member_abstracts
-  - only_throw_errors
-  - overridden_fields
-  - package_names
-  - package_prefixed_library_names
-  - prefer_adjacent_string_concatenation
-  - prefer_collection_literals
-  - prefer_conditional_assignment
-  - prefer_contains
-  - prefer_final_fields
-  - prefer_final_locals
-  - prefer_for_elements_to_map_fromIterable
-  - prefer_generic_function_type_aliases
-  - prefer_if_null_operators
-  - prefer_is_empty
-  - prefer_is_not_empty
-  - prefer_iterable_whereType
-  - prefer_null_aware_operators
-  - prefer_single_quotes
-  - prefer_spread_collections
-  - prefer_typing_uninitialized_variables
-  - recursive_getters
-  - slash_for_doc_comments
-  - test_types_in_equals
-  - throw_in_finally
-  - type_init_formals
-  - unawaited_futures
-  - unnecessary_brace_in_string_interps
-  - unnecessary_const
-  - unnecessary_getters_setters
-  - unnecessary_new
-  - unnecessary_null_in_if_null_operators
-  - unnecessary_this
-  - unrelated_type_equality_checks
-  - use_function_type_syntax_for_parameters
-  - use_rethrow_when_possible
-  - valid_regexps
+    - always_declare_return_types
+    - annotate_overrides
+    - avoid_empty_else
+    - avoid_init_to_null
+    - avoid_null_checks_in_equality_operators
+    - avoid_relative_lib_imports
+    - avoid_return_types_on_setters
+    - avoid_shadowing_type_parameters
+    - avoid_types_as_parameter_names
+    - await_only_futures
+    - camel_case_extensions
+    - camel_case_types
+    - cancel_subscriptions
+    - close_sinks
+    - collection_methods_unrelated_type
+    - comment_references
+    - constant_identifier_names
+    - control_flow_in_finally
+    - curly_braces_in_flow_control_structures
+    - dangling_library_doc_comments
+    - directives_ordering
+    - empty_catches
+    - empty_constructor_bodies
+    - empty_statements
+    - hash_and_equals
+    - implementation_imports
+    - library_annotations
+    - library_names
+    - library_prefixes
+    - literal_only_boolean_expressions
+    - no_duplicate_case_values
+    - non_constant_identifier_names
+    - null_closures
+    #- omit_local_variable_types
+    - one_member_abstracts
+    - only_throw_errors
+    - overridden_fields
+    - package_names
+    - package_prefixed_library_names
+    - prefer_adjacent_string_concatenation
+    - prefer_collection_literals
+    - prefer_conditional_assignment
+    - prefer_contains
+    - prefer_final_fields
+    - prefer_final_locals
+    - prefer_for_elements_to_map_fromIterable
+    - prefer_generic_function_type_aliases
+    - prefer_if_null_operators
+    - prefer_is_empty
+    - prefer_is_not_empty
+    - prefer_iterable_whereType
+    - prefer_null_aware_operators
+    - prefer_single_quotes
+    - prefer_spread_collections
+    - prefer_typing_uninitialized_variables
+    - recursive_getters
+    - slash_for_doc_comments
+    - test_types_in_equals
+    - throw_in_finally
+    - type_init_formals
+    - unawaited_futures
+    - unnecessary_brace_in_string_interps
+    - unnecessary_const
+    - unnecessary_getters_setters
+    - unnecessary_library_name
+    - unnecessary_library_directive
+    - unnecessary_new
+    - unnecessary_null_in_if_null_operators
+    - unnecessary_this
+    - unrelated_type_equality_checks
+    - use_function_type_syntax_for_parameters
+    - use_rethrow_when_possible
+    - use_string_in_part_of_directives
+    - valid_regexps

app/lib/account/session_cookie.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Logic to do with session cookie parsing and reading.
-library session_cookie;
+library;
 
 import 'dart:io' show HttpHeaders;
 

app/lib/admin/tools/delete_all_staging.dart

@@ -87,7 +87,7 @@ Future<void> _batchedQuery<T extends Model>(
 
   void flush() {
     if (keys.isEmpty) return;
-    fn(List.from(keys));
+    fn(List.of(keys));
     keys.clear();
     budget = _defaultBudget;
   }

app/lib/admin/tools/recent_uploaders.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Creates a report about recent uploaders.
+library;
 
 import 'dart:async';
 import 'dart:convert';

app/lib/fake/backend/fake_pub_worker.dart

@@ -15,7 +15,6 @@ import 'package:gcloud/service_scope.dart';
 import 'package:http/http.dart';
 import 'package:http_parser/http_parser.dart';
 import 'package:indexed_blob/indexed_blob.dart';
-import 'package:meta/meta.dart';
 import 'package:pana/pana.dart';
 import 'package:path/path.dart' as p;
 import 'package:pub_dev/fake/backend/fake_pana_runner.dart';
@@ -303,8 +302,7 @@ Future<void> _upload(
       );
     }, retryIf: (e) => e is IOException || e is IntermittentUploadException);
 
-@sealed
-class UploadException implements Exception {
+final class UploadException implements Exception {
   final String message;
 
   UploadException(this.message);
@@ -313,8 +311,7 @@ class UploadException implements Exception {
   String toString() => message;
 }
 
-@sealed
-class IntermittentUploadException extends UploadException {
+final class IntermittentUploadException extends UploadException {
   IntermittentUploadException(String message) : super(message);
 }
 

app/lib/frontend/handlers.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library pub_dartlang_org.handlers;
-
 import 'package:logging/logging.dart';
 import 'package:shelf/shelf.dart' as shelf;
 import 'package:shelf_router/shelf_router.dart';

app/lib/frontend/handlers/account.dart

@@ -203,9 +203,10 @@ Future<LikedPackagesResponse> listPackageLikesHandler(
   final authenticatedUser = await requireAuthenticatedWebUser();
   final user = authenticatedUser.user;
   final packages = await likeBackend.listPackageLikes(user);
-  final List<PackageLikeResponse> packageLikes = List.from(packages.map(
-      (like) => PackageLikeResponse(
-          liked: true, package: like.package, created: like.created)));
+  final List<PackageLikeResponse> packageLikes = packages
+      .map((like) => PackageLikeResponse(
+          liked: true, package: like.package, created: like.created))
+      .toList();
   return LikedPackagesResponse(likedPackages: packageLikes);
 }
 

app/lib/frontend/handlers/atom_feed.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library pub_dartlang_org.atom_feed;
-
 import 'dart:async';
 import 'dart:convert';
 

app/lib/frontend/handlers/custom_api.dart

@@ -461,8 +461,7 @@ Future<shelf.Response> apiSearchHandler(shelf.Request request) async {
     if (sr.errorMessage != null) 'message': sr.errorMessage,
   };
   if (hasNextPage) {
-    final newParams =
-        Map<String, dynamic>.from(request.requestedUri.queryParameters);
+    final newParams = {...request.requestedUri.queryParameters};
     newParams['page'] = (searchForm.currentPage! + 1).toString();
     final nextPageUrl =
         request.requestedUri.replace(queryParameters: newParams).toString();

app/lib/frontend/handlers/redirects.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library pub_dartlang_org.handlers_redirects;
-
 import 'package:shelf/shelf.dart';
 import 'package:shelf_router/shelf_router.dart';