Simpler deletion rules + daily scan.

Author: isoos

app/lib/admin/backend.dart

@@ -784,7 +784,7 @@ class AdminBackend {
   Future<void> deleteModerationCases({
     @visibleForTesting DateTime? before,
   }) async {
-    before ??= clock.ago(days: 3 * 366).toUtc(); // extra buffer days
+    before ??= clock.ago(days: 3 * 365).toUtc();
 
     /// Querying the cases that were opened before the threshold,
     /// as the resolved timestamp may be null for ongoing cases.
@@ -796,10 +796,6 @@ class AdminBackend {
       if (mc.opened.isAfter(before)) {
         continue;
       }
-      final resolved = mc.resolved;
-      if (resolved == null || resolved.isAfter(before)) {
-        continue;
-      }
       // delete the entity
       _logger.info('Deleting ModerationCase: ${mc.caseId}');
       await _db.commit(deletes: [mc.key]);

app/lib/tool/neat_task/pub_dev_tasks.dart

@@ -136,18 +136,18 @@ List<NeatPeriodicTaskScheduler> createPeriodicTaskSchedulers({
       task: () async => await apiExporter.synchronizeExportedApi(),
     ),
 
-    // Deletes admin-deleted entities.
-    _weekly(
-      name: 'delete-admin-deleted-entities',
+    // Deletes ModerationCase entities.
+    _daily(
+      name: 'delete-moderation-cases',
       isRuntimeVersioned: false,
-      task: () async => adminBackend.deleteAdminDeletedEntities(),
+      task: () async => adminBackend.deleteModerationCases(),
     ),
 
-    // Deletes ModerationCase entities.
+    // Deletes admin-deleted entities.
     _weekly(
-      name: 'delete-moderation-cases',
+      name: 'delete-admin-deleted-entities',
       isRuntimeVersioned: false,
-      task: () async => adminBackend.deleteModerationCases(),
+      task: () async => adminBackend.deleteAdminDeletedEntities(),
     ),
 
     // Deletes moderated packages, versions, publishers and users.