Skip to content

Commit 9fdd235

Browse files
authored
Enable experiments (#8551)
1 parent 3f821b1 commit 9fdd235

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+107
-19
lines changed

app/lib/frontend/handlers/experimental.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,13 @@ class ExperimentalFlags {
9292
return params;
9393
}
9494

95-
bool get isSearchCompletionEnabled => isEnabled('search-completion');
95+
bool get isSearchCompletionEnabled => true;
9696
bool get isSearchTopicsEnabled => isEnabled('search-topics');
9797

98-
bool get isDarkModeEnabled => isEnabled('dark');
98+
bool get isDarkModeEnabled => true;
9999
bool get isDarkModeDefault => isEnabled('dark-as-default');
100100

101-
bool get showDownloadCountsVersionChart =>
102-
isEnabled('download-counts-version-chart');
101+
bool get showDownloadCountsVersionChart => true;
103102

104103
String encodedAsCookie() => _enabled.join(':');
105104

app/lib/frontend/templates/views/shared/layout.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,6 @@ d.Node pageLayoutNode({
161161
'body',
162162
classes: [
163163
...?bodyClasses,
164-
if (requestContext.experimentalFlags.isDarkModeEnabled)
165-
'-experimental-dark-mode',
166164
requestContext.experimentalFlags.isDarkModeDefault
167165
? 'dark-theme'
168166
: 'light-theme',

app/test/frontend/golden/authorized_page.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ <h3 class="foldable-button">
104104
</div>
105105
</div>
106106
</nav>
107+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
107108
</div>
108109
<div id="banner-container"></div>
109110
<main class="container">

app/test/frontend/golden/consent_page.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ <h3 class="foldable-button">
104104
</div>
105105
</div>
106106
</nav>
107+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
107108
</div>
108109
<div id="banner-container"></div>
109110
<main class="container">

app/test/frontend/golden/create_publisher_page.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ <h3 class="foldable-button">
103103
</div>
104104
</div>
105105
</nav>
106+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
106107
</div>
107108
<div id="banner-container"></div>
108109
<main class="container">

app/test/frontend/golden/error_page.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,13 @@ <h3 class="foldable-button">
9898
</div>
9999
</div>
100100
</nav>
101+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
101102
</div>
102103
<div id="banner-container"></div>
103104
<div class="_banner-bg">
104105
<div class="container">
105106
<form class="search-bar banner-item" action="/packages" autocomplete="off">
106-
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
107+
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
107108
<span class="icon"></span>
108109
</form>
109110
</div>

app/test/frontend/golden/help_page.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ <h3 class="foldable-button">
104104
</div>
105105
</div>
106106
</nav>
107+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
107108
</div>
108109
<div id="banner-container"></div>
109110
<main class="container">

app/test/frontend/golden/landing_page.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,15 @@ <h3 class="foldable-button">
9898
</div>
9999
</div>
100100
</nav>
101+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
101102
</div>
102103
<div id="banner-container"></div>
103104
<div class="_banner-bg">
104105
<div class="container home-banner">
105106
<h2 class="_visuallyhidden">pub.dev package manager</h2>
106107
<img class="logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="328" height="70" role="presentation"/>
107108
<form class="search-bar banner-item" action="/packages" autocomplete="off">
108-
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
109+
<input class="input" type="search" name="q" placeholder="Search packages" autocomplete="off" autofocus="autofocus" title="Search" data-widget="completion" data-completion-src="/api/search-input-completion-data" data-completion-class="search-completion"/>
109110
<span class="icon"></span>
110111
</form>
111112
<p class="text">

app/test/frontend/golden/my_activity_log_page.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ <h3 class="foldable-button">
130130
</div>
131131
</div>
132132
</nav>
133+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
133134
</div>
134135
<div id="banner-container"></div>
135136
<main class="-wide-header-detail-page">

app/test/frontend/golden/my_liked_packages.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ <h3 class="foldable-button">
131131
</div>
132132
</div>
133133
</nav>
134+
<button class="-pub-theme-toggle" aria-label="light/dark theme toggle"></button>
134135
</div>
135136
<div id="banner-container"></div>
136137
<main class="-wide-header-detail-page">

0 commit comments

Comments
 (0)