Fix ARIA label for the logo pointing to the pub landing page. (#8482)

Author: isoos

app/lib/dartdoc/dartdoc_page.dart

@@ -153,8 +153,11 @@ extension DartDocPageRender on DartDocPage {
           href: '/',
           classes: ['hidden-xs'],
           child: d.img(
-            // TODO: Move this into a class
-            attributes: {'style': 'height: 30px; margin-right: 1em;'},
+            attributes: {
+              'aria-label': 'Go to the landing page of pub.dev',
+              // TODO: Move this into a class
+              'style': 'height: 30px; margin-right: 1em;',
+            },
             image: d.Image.decorative(
               src: staticUrls.dartLogoSvg,
               height: 30,

app/lib/frontend/templates/views/shared/site_header.dart

@@ -24,6 +24,9 @@ d.Node siteHeaderNode({
         d.a(
           classes: ['logo'],
           href: '/',
+          attributes: {
+            'aria-label': 'Go to the landing page of pub.dev',
+          },
           child: d.img(
             classes: ['site-logo'],
             image: d.Image.decorative(

app/test/frontend/golden/authorized_page.html

@@ -35,7 +35,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>

app/test/frontend/golden/consent_page.html

@@ -35,7 +35,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>

app/test/frontend/golden/create_publisher_page.html

@@ -34,7 +34,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>

app/test/frontend/golden/error_page.html

@@ -34,7 +34,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>

app/test/frontend/golden/help_page.html

@@ -35,7 +35,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>

app/test/frontend/golden/my_activity_log_page.html

@@ -35,7 +35,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>

app/test/frontend/golden/my_liked_packages.html

@@ -36,7 +36,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>

app/test/frontend/golden/my_packages.html

@@ -35,7 +35,7 @@
     <noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
     <div class="site-header">
       <button class="hamburger" aria-label="menu toggle"></button>
-      <a class="logo" href="/">
+      <a class="logo" href="/" aria-label="Go to the landing page of pub.dev">
         <img class="site-logo" src="/static/hash-%%etag%%/img/pub-dev-logo.svg" alt="" width="140" height="30" role="presentation"/>
       </a>
       <div class="site-header-space"></div>