Skip to content

Commit e2358ee

Browse files
committed
Use little endian
1 parent d0c2b40 commit e2358ee

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/_pub_shared/lib/format/encoding.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import 'dart:typed_data';
1010
String encodeIntsAsBigEndianBase64String(List<int> dataPoints) {
1111
final byteData = ByteData(4 * dataPoints.length);
1212
for (int i = 0; i < dataPoints.length; i++) {
13-
byteData.setUint32(4 * i, dataPoints[i]);
13+
byteData.setUint32(4 * i, dataPoints[i], Endian.little);
1414
}
1515
return base64Encode(byteData.buffer.asUint8List());
1616
}
@@ -22,7 +22,7 @@ List<int> decodeIntsFromBigEndianBase64String(String encoded) {
2222
final dataPoints = List.filled(resLength, -1);
2323
final sublist = ByteData.sublistView(bytes);
2424
for (int i = 0; i < resLength; i++) {
25-
dataPoints[i] = sublist.getUint32(4 * i);
25+
dataPoints[i] = sublist.getUint32(4 * i, Endian.little);
2626
}
2727
return dataPoints;
2828
}

pkg/_pub_shared/test/format/encoding_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ void main() {
99
test('encode/decode success', () {
1010
final data = [1, 2, 3, 4, 5, 6, 7, 8, 9];
1111
final encoded = encodeIntsAsBigEndianBase64String(data);
12-
expect(encoded, 'AAAAAQAAAAIAAAADAAAABAAAAAUAAAAGAAAABwAAAAgAAAAJ');
12+
expect(encoded, 'AQAAAAIAAAADAAAABAAAAAUAAAAGAAAABwAAAAgAAAAJAAAA');
1313
expect(decodeIntsFromBigEndianBase64String(encoded), data);
1414
});
1515

@@ -23,7 +23,7 @@ void main() {
2323
test('encode/decode failure with negative integers', () {
2424
final data = <int>[-1, -2];
2525
final encoded = encodeIntsAsBigEndianBase64String(data);
26-
expect(encoded, '//////////4=');
26+
expect(encoded, '//////7///8=');
2727
expect(decodeIntsFromBigEndianBase64String(encoded), isNot(data));
2828
});
2929
}

0 commit comments

Comments
 (0)