Fixing apiExporter's scope.

Author: isoos

app/test/package/api_export/api_exporter_test.dart

@@ -13,7 +13,7 @@ import 'package:googleapis/storage/v1.dart' show DetailedApiRequestError;
 import 'package:logging/logging.dart';
 import 'package:pub_dev/fake/backend/fake_auth_provider.dart';
 import 'package:pub_dev/package/api_export/api_exporter.dart';
-import 'package:pub_dev/shared/datastore.dart';
+import 'package:pub_dev/shared/configuration.dart';
 import 'package:pub_dev/shared/storage.dart';
 import 'package:pub_dev/shared/utils.dart';
 import 'package:pub_dev/shared/versions.dart';
@@ -49,15 +49,19 @@ void main() {
         'SHOUT Deleting object from public bucket: "packages/bar-2.0.0.tar.gz".',
         'SHOUT Deleting object from public bucket: "packages/bar-3.0.0.tar.gz".',
       ], (fakeTime) async {
-    await storageService.createBucket('bucket');
-    final bucket = storageService.bucket('bucket');
-    final apiExporter =
-        ApiExporter(dbService, storageService: storageService, bucket: bucket);
+    // Since we want to verify post-upload tasks triggering API exporter,
+    // we cannot use an isolated instance, we need to use the same setup.
+    // However, for better control and consistency, we can remove all the
+    // existing files from the bucket at the start of this test:
+    await apiExporter!.stop();
+    final bucket =
+        storageService.bucket(activeConfiguration.exportedApiBucketName!);
+    await _deleteAll(bucket);
 
     await _testExportedApiSynchronization(
       fakeTime,
       bucket,
-      apiExporter.synchronizeExportedApi,
+      apiExporter!.synchronizeExportedApi,
     );
   });
 
@@ -69,26 +73,38 @@ void main() {
     ],
     testProfile: _testProfile,
     (fakeTime) async {
-      await storageService.createBucket('bucket');
-      final bucket = storageService.bucket('bucket');
-      final apiExporter = ApiExporter(dbService,
-          storageService: storageService, bucket: bucket);
+    // Since we want to verify post-upload tasks triggering API exporter,
+    // we cannot use an isolated instance, we need to use the same setup.
+    // However, for better control and consistency, we can remove all the
+    // existing files from the bucket at the start of this test:
+      await apiExporter!.stop();
+      final bucket =
+          storageService.bucket(activeConfiguration.exportedApiBucketName!);
+      await _deleteAll(bucket);
 
-      await apiExporter.synchronizeExportedApi();
+      await apiExporter!.synchronizeExportedApi();
 
-      await apiExporter.start();
+      await apiExporter!.start();
 
       await _testExportedApiSynchronization(
         fakeTime,
         bucket,
         () async => await fakeTime.elapse(minutes: 15),
       );
 
-      await apiExporter.stop();
+      await apiExporter!.stop();
     },
   );
 }
 
+Future<void> _deleteAll(Bucket bucket) async {
+  await for (final entry in bucket.list(delimiter: '')) {
+    if (entry.isObject) {
+      await bucket.delete(entry.name);
+    }
+  }
+}
+
 Future<void> _testExportedApiSynchronization(
   FakeTime fakeTime,
   Bucket bucket,