Fix tests

Author: jonasfj

app/lib/package/api_export/api_exporter.dart

@@ -4,11 +4,13 @@
 
 import 'dart:async';
 
+import 'package:_pub_shared/data/package_api.dart';
 import 'package:clock/clock.dart';
 import 'package:gcloud/service_scope.dart' as ss;
 import 'package:gcloud/storage.dart';
 import 'package:logging/logging.dart';
 import 'package:pub_dev/service/security_advisories/backend.dart';
+import 'package:pub_dev/shared/exceptions.dart';
 import 'package:pub_dev/shared/parallel_foreach.dart';
 
 import '../../search/backend.dart';
@@ -164,9 +166,20 @@ class ApiExporter {
   Future<void> synchronizePackage(String package) async {
     _log.info('synchronizePackage("$package")');
 
-    // TODO: Handle the case where [package] is deleted or invisible!
-    // TODO: We may need to delete the package, but only if it's not too recent!
-    final versionListing = await packageBackend.listVersions(package);
+    final PackageData versionListing;
+    try {
+      versionListing = await packageBackend.listVersions(package);
+    } on NotFoundException {
+      // Handle the case where package is moderated.
+      final pkg = await packageBackend.lookupPackage(package);
+      if (pkg != null && pkg.isNotVisible) {
+        // We only delete the package if it is explicitly not visible.
+        // If we can't find it, then it's safer to assume that it's a bug.
+        await _api.package(package).delete();
+      }
+      return;
+    }
+
     // TODO: Consider skipping the cache when fetching security advisories
     final advisories = await securityAdvisoryBackend.listAdvisoriesResponse(
       package,

app/test/package/api_export/api_exporter_test.dart

@@ -9,6 +9,7 @@ import 'package:_pub_shared/data/admin_api.dart';
 import 'package:_pub_shared/data/package_api.dart';
 import 'package:gcloud/storage.dart';
 import 'package:googleapis/storage/v1.dart' show DetailedApiRequestError;
+import 'package:logging/logging.dart';
 import 'package:pub_dev/fake/backend/fake_auth_provider.dart';
 import 'package:pub_dev/package/api_export/api_exporter.dart';
 import 'package:pub_dev/shared/storage.dart';
@@ -23,6 +24,8 @@ import '../../shared/test_models.dart';
 import '../../shared/test_services.dart';
 import '../../task/fake_time.dart';
 
+final _log = Logger('api_export.test');
+
 final _testProfile = TestProfile(
   defaultUser: userAtPubDevEmail,
   packages: [
@@ -55,7 +58,6 @@ void main() {
   testWithFakeTime(
     'apiExporter.start()',
     testProfile: _testProfile,
-    skip: 'Fix this test!',
     (fakeTime) async {
       await storageService.createBucket('bucket');
       final bucket = storageService.bucket('bucket');
@@ -68,7 +70,7 @@ void main() {
       await _testExportedApiSynchronization(
         fakeTime,
         bucket,
-        () async => await fakeTime.elapse(hours: 3),
+        () async => await fakeTime.elapse(minutes: 15),
       );
 
       await apiExporter.stop();
@@ -81,7 +83,7 @@ Future<void> _testExportedApiSynchronization(
   Bucket bucket,
   Future<void> Function() synchronize,
 ) async {
-  // ## Existing package
+  _log.info('## Existing package');
   {
     await synchronize();
 
@@ -121,7 +123,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## New package
+  _log.info('## New package');
   {
     await importProfile(
       source: ImportSource.autoGenerated(),
@@ -167,7 +169,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## New package version
+  _log.info('## New package version');
   {
     await importProfile(
       source: ImportSource.autoGenerated(),
@@ -206,7 +208,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## Discontinued flipped on
+  _log.info('## Discontinued flipped on');
   {
     final api = await createFakeAuthPubApiClient(email: userAtPubDevEmail);
     await api.setPackageOptions(
@@ -229,7 +231,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## Discontinued flipped off
+  _log.info('## Discontinued flipped off');
   {
     final api = await createFakeAuthPubApiClient(email: userAtPubDevEmail);
     await api.setPackageOptions(
@@ -251,7 +253,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## Version retracted
+  _log.info('## Version retracted');
   {
     final api = await createFakeAuthPubApiClient(email: userAtPubDevEmail);
     await api.setVersionOptions(
@@ -274,7 +276,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## Version moderated
+  _log.info('## Version moderated');
   {
     // Elapse time before moderating package, because exported-api won't delete
     // recently created files as a guard against race conditions.
@@ -315,7 +317,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## Version reinstated
+  _log.info('## Version reinstated');
   {
     final adminApi = createPubApiClient(
       authToken: createFakeServiceAccountToken(email: '[email protected]'),
@@ -352,7 +354,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## Package moderated
+  _log.info('## Package moderated');
   {
     // Elapse time before moderating package, because exported-api won't delete
     // recently created files as a guard against race conditions.
@@ -387,7 +389,7 @@ Future<void> _testExportedApiSynchronization(
     );
   }
 
-  // ## Package reinstated
+  _log.info('## Package reinstated');
   {
     final adminApi = createPubApiClient(
       authToken: createFakeServiceAccountToken(email: '[email protected]'),