Skip to content

Commit ee40d08

Browse files
authored
Adjust downloads sparkline chart (#8254)
1 parent 29eed4e commit ee40d08

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

app/lib/frontend/templates/views/pkg/info_box.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ d.Node packageInfoBoxNode({
7272
}
7373
return d.fragment([
7474
labeledScores,
75-
if (data.weeklyDownloadCounts != null &&
76-
requestContext.experimentalFlags.showDownloadCounts)
77-
_block('Weekly Downloads', _downloadsChart(data.weeklyDownloadCounts!)),
7875
if (thumbnailUrl != null)
7976
d.div(classes: [
8077
'detail-screenshot-thumbnail'
@@ -86,6 +83,9 @@ d.Node packageInfoBoxNode({
8683
collectionsIcon(),
8784
]),
8885
_publisher(package.publisherId),
86+
if (data.weeklyDownloadCounts != null &&
87+
requestContext.experimentalFlags.showDownloadCounts)
88+
_block('Weekly Downloads', _downloadsChart(data.weeklyDownloadCounts!)),
8989
_metadata(
9090
description: version.pubspec!.description,
9191
metaLinks: metaLinks,

pkg/web_app/lib/src/widget/weekly_sparkline/widget.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,16 @@ void create(HTMLElement element, Map<String, String> options) {
2525
final decoded = decodeIntsFromLittleEndianBase64String(dataPoints);
2626
final newestDate = DateTime.fromMillisecondsSinceEpoch(decoded[0] * 1000);
2727
final weeklyDownloads = decoded.sublist(1);
28+
29+
// TODO(https://github.com/dart-lang/pub-dev/issues/8251): Update this to 52.
30+
final dataListLength =
31+
weeklyDownloads.length > 40 ? 40 : weeklyDownloads.length;
2832
return List.generate(
2933
weeklyDownloads.length,
3034
(i) => (
3135
date: newestDate.copyWith(day: newestDate.day - 7 * i),
3236
downloads: weeklyDownloads[i]
33-
)).reversed.toList();
37+
)).sublist(0, dataListLength).reversed.toList();
3438
}
3539

3640
drawChart(svg, toolTip, chartSubText, prepareDataForSparkline(dataPoints));
@@ -94,7 +98,7 @@ void drawChart(Element svg, HTMLDivElement toolTip, HTMLDivElement chartSubText,
9498

9599
sparklineSpot
96100
..setAttribute('class', 'weekly-sparkline')
97-
..setAttribute('r', '2');
101+
..setAttribute('r', '3');
98102

99103
sparklineBar.setAttribute('class', 'weekly-sparkline-bar');
100104
sparklineBar.setAttribute('x1', '0');

0 commit comments

Comments
 (0)