Apply suggestions from code review

jonasfj · isoos · web-flow · commit eeab3604bc9a · 2024-10-15T15:50:30.000+02:00
Co-authored-by: István Soós &lt;isoos@users.noreply.github.com&gt;
diff --git a/app/lib/shared/utils.dart b/app/lib/shared/utils.dart
@@ -312,10 +312,10 @@ extension StringExt on String {
   /// ```
   String without({String prefix = '', String suffix = ''}) {
     var val = this;
-    if (startsWith(prefix)) {
+    if (prefix.isNotEmpty && startsWith(prefix)) {
       val = val.substring(prefix.length);
     }
-    if (endsWith(suffix)) {
+    if (suffix.isNotEmpty && endsWith(suffix)) {
       val = val.substring(0, val.length - suffix.length);
     }
     return val;

Original file line number	Diff line number	Diff line change
`@@ -312,10 +312,10 @@ extension StringExt on String {`
`312`	`312`	/// ```
`313`	`313`	`String without({String prefix = '', String suffix = ''}) {`
`314`	`314`	`var val = this;`
`315`		`- if (startsWith(prefix)) {`
	`315`	`+ if (prefix.isNotEmpty && startsWith(prefix)) {`
`316`	`316`	`val = val.substring(prefix.length);`
`317`	`317`	`}`
`318`		`- if (endsWith(suffix)) {`
	`318`	`+ if (suffix.isNotEmpty && endsWith(suffix)) {`
`319`	`319`	`val = val.substring(0, val.length - suffix.length);`
`320`	`320`	`}`
`321`	`321`	`return val;`