Skip to content

Defending pana log writes from cross-stream data. #8069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Defending pana log writes from cross-stream data. #8069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/pub_worker/lib/src/analyze.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';
import 'dart:convert' show JsonUtf8Encoder, utf8;
import 'dart:convert' show JsonUtf8Encoder, LineSplitter, Utf8Decoder, utf8;
import 'dart:io'
show Directory, File, IOException, Platform, Process, ProcessSignal, gzip;
import 'dart:isolate' show Isolate;
Expand Down Expand Up @@ -152,8 +152,14 @@ Future<void> _analyzePackage(
await pana.stdin.close();

await Future.wait<void>([
pana.stderr.forEach(log.add),
pana.stdout.forEach(log.add),
pana.stderr
.transform(Utf8Decoder(allowMalformed: true))
.transform(LineSplitter())
.forEach(log.writeln),
pana.stdout
.transform(Utf8Decoder(allowMalformed: true))
.transform(LineSplitter())
.forEach(log.writeln),
pana.exitOrTimeout(_panaTimeout, () {
log.writeln('TIMEOUT: pana sending SIGTERM/SIGKILL');
}),
Expand Down
Loading