Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 29, 2024

  • Follow-up to Detect redirecting page in the dartdoc-generated output + render in-place #8342, implementing the redirect instead of in-place rendering.
  • Updated the document serving handler by adding a second cached value about the status of a page, whether is served, missing or redirected.
  • Optimized the code for the optimistic happy path, trying to serve the cached bytes first (if any), then trying the cached status (if any), then calculating and updating both as the final fallback path.
  • Added a test that should fail / should be updated when we migrate to 8.3 dartdoc.

@isoos isoos requested review from jonasfj and sigurdm November 29, 2024 17:05
@isoos
Copy link
Collaborator Author

isoos commented Nov 29, 2024

Note: this is available on staging and can be tried on the analyzer package.

Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, perhaps move the sanity check from the handler to the dartdoc post-processing (and consider logging if a violation is found).

@isoos isoos merged commit c75370f into dart-lang:master Dec 2, 2024
32 checks passed
@isoos isoos deleted the dartdoc-redirect branch December 2, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants