Skip to content

Run all periodic task + another integrity check after each test. #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

Run all periodic task + another integrity check after each test. #8359

merged 2 commits into from
Dec 17, 2024

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Dec 5, 2024

  • Follow-up to Migrate isBlocked flags to isModerated. #8356.
  • Split the creation of the tasks from starting them, so we can selectively run them at the end of the test cases.
  • Also updated the testWithFakeTime to use the same verification.

@isoos isoos requested review from jonasfj and sigurdm December 5, 2024 11:00
@isoos isoos merged commit 25664aa into dart-lang:master Dec 17, 2024
32 checks passed
@isoos isoos deleted the post-test-check branch December 17, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @sigurdm