Skip to content

Fix fake_gcloud list() iteration #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix fake_gcloud list() iteration #8428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/test/admin/exported_api_sync_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,7 @@ void main() {
});
});

testWithProfile('deleted files + full sync', expectedLogMessages: [
// TODO: review why we have unhandled errors here
RegExp(r'^SEVERE Unhandled error in API handler \(incidentId: .*\)'),
], fn: () async {
testWithProfile('deleted files + full sync', fn: () async {
await syncExportedApi();
final oldRoot = await listExportedApi();

Expand Down
2 changes: 1 addition & 1 deletion pkg/fake_gcloud/lib/mem_storage.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ class _Bucket implements Bucket {
final isDirPrefix =
prefix.isEmpty || (delimiter.isNotEmpty && prefix.endsWith(delimiter));
final segments = <String>{};
for (final name in _files.keys) {
for (final name in [..._files.keys]) {
bool matchesPrefix() {
// without prefix, return everything
if (prefix!.isEmpty) return true;
Expand Down
Loading