Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Feb 5, 2025

  • Opacity change on hover may not be a good idea #8493
  • Setting the filter: brightness(...%) is much better for our links, as their color is now pushed towards stronger contrast.
  • However, it does not work with the monochrome icons, introducing a new class for it and using it on the version's tab icons.

Hovering on the versions tab icons before:
image
image

Hovering on the versions tab icons after:
image
image

Note: the difference is that the current behavior reduced the contrast, while the new one increases it. It can also be tested on staging now.

@isoos isoos requested review from jonasfj and sigurdm February 5, 2025 15:58
@isoos
Copy link
Collaborator Author

isoos commented Feb 5, 2025

/cc @parlough

@isoos isoos merged commit 4c262e1 into dart-lang:master Feb 6, 2025
32 checks passed
@isoos isoos deleted the brightness branch February 6, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants