Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Feb 6, 2025

  • I think the font-families are rather similar to --pub-color-<x>, we should define them as --pub-font-family-<x>.
  • Dropping the default- part, as I don't think we will have too many different cases.
  • Using body instead of default, I think it reads better.

@isoos isoos requested review from jonasfj and sigurdm February 6, 2025 16:39
@isoos
Copy link
Collaborator Author

isoos commented Feb 6, 2025

/cc @parlough

@isoos isoos merged commit 169bb69 into dart-lang:master Feb 7, 2025
31 checks passed
@isoos isoos deleted the font-variables branch February 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants