Reduce flaky screenshots. #8603

isoos · 2025-02-28T13:04:13Z

Tracking causes that make screenshots flaky #8580
Adds a generic -pub-ongoing-screenshot class to the <body> element, that can be used to introduce styles that are scoped to be present only for screenshotting.
Setting the caret (blinking cursor) to transparent, so that it doesn't matter in which blink state it is in.
Overriding transition duration to zero.
Waiting an arbitrary small time after updating the styles and viewport, but before taking the screenshot in the hope it stabilizes the view better.

isoos assigned jonasfj and sigurdm Feb 28, 2025

isoos changed the title ~~Reduce flaky css screenshots.~~ Reduce flaky screenshots. Feb 28, 2025

isoos unassigned jonasfj and sigurdm Mar 3, 2025

isoos requested review from jonasfj and sigurdm March 3, 2025 11:29

isoos force-pushed the flaky-screenshots branch from 84b3e76 to bfa4985 Compare March 3, 2025 11:30

sigurdm approved these changes Mar 3, 2025

View reviewed changes

isoos force-pushed the flaky-screenshots branch from bfa4985 to adfcbdc Compare March 3, 2025 13:06

Reduce flaky css screenshots.

adfcbdc

isoos merged commit 9c22fbf into dart-lang:master Mar 3, 2025
31 checks passed

isoos deleted the flaky-screenshots branch March 3, 2025 13:30

Update expression test.

c01b0e2

isoos added a commit to isoos/pub-dev that referenced this pull request Mar 5, 2025

Reduce flaky screenshots. (dart-lang#8603)

ac22a83

Provide feedback