Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Apr 7, 2025

No description provided.

@isoos isoos requested review from jonasfj and sigurdm April 7, 2025 19:38
@isoos isoos marked this pull request as draft April 7, 2025 19:45
@isoos
Copy link
Collaborator Author

isoos commented Apr 7, 2025

Note: for some reason the fake-time based exporter test fails, and I couldn't figure out the reason yet. I think the rest of the change is worth for a review though.

@isoos isoos marked this pull request as ready for review April 8, 2025 09:35
@isoos
Copy link
Collaborator Author

isoos commented Apr 8, 2025

Note: I've found and fixed the test issue: we were using two different instance of ApiExporter in two different scope. Fixing that by resetting the existing one at the beginning of the tests.

@isoos isoos merged commit 32ade8b into dart-lang:master Apr 9, 2025
31 checks passed
@isoos isoos deleted the feed-atom branch April 9, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants