Skip to content

Updated metadata and labels for RSS/atom feeds. #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Updated metadata and labels for RSS/atom feeds. #8706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/lib/frontend/handlers/atom_feed.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,7 @@ Feed _allPackagesFeed(List<PackageVersion> versions) {
}

return Feed(
title: 'Pub Packages for Dart',
subTitle: 'Last Updated Packages',
author: 'Dart Team',
title: 'Recently published packages on pub.dev',
alternateUrl: activeConfiguration.primarySiteUri.resolve('/').toString(),
selfUrl:
activeConfiguration.primarySiteUri.resolve('/feed.atom').toString(),
Expand All @@ -222,7 +220,7 @@ Feed _allPackagesFeed(List<PackageVersion> versions) {

Feed _packageFeed(String package, List<PackageVersion> versions) {
return Feed(
title: 'Most recently published versions for package $package',
title: 'Recently published versions of package $package on pub.dev',
alternateUrl: activeConfiguration.primarySiteUri
.resolve(urls.pkgPageUrl(package))
.toString(),
Expand Down
8 changes: 2 additions & 6 deletions app/test/frontend/handlers/atom_feed_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,11 @@ void main() {

final restExp = RegExp('<feed xmlns="http://www.w3.org/2005/Atom">\n'
' <id>${activeConfiguration.primarySiteUri}/feed.atom</id>\n'
' <title>Pub Packages for Dart</title>\n'
' <title>Recently published packages on pub.dev</title>\n'
' <updated>(.*)</updated>\n'
' <author>\n'
' <name>Dart Team</name>\n'
' </author>\n'
' <link href="${activeConfiguration.primarySiteUri}/" rel="alternate"/>\n'
' <link href="${activeConfiguration.primarySiteUri}/feed.atom" rel="self"/>\n'
' <generator version="0.1.0">Pub Feed Generator</generator>\n'
' <subtitle>Last Updated Packages</subtitle>\n'
'(\\s*)'
'</feed>');
expect(
Expand Down Expand Up @@ -115,7 +111,7 @@ void main() {

final restExp = RegExp('<feed xmlns="http://www.w3.org/2005/Atom">\n'
' <id>${activeConfiguration.primarySiteUri}/packages/oxygen/feed.atom</id>\n'
' <title>Most recently published versions for package oxygen</title>\n'
' <title>Recently published versions of package oxygen on pub.dev</title>\n'
' <updated>(.*)</updated>\n'
' <link href="${activeConfiguration.primarySiteUri}/packages/oxygen" rel="alternate"/>\n'
' <link href="${activeConfiguration.primarySiteUri}/packages/oxygen/feed.atom" rel="self"/>\n'
Expand Down