Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ AppEngine version, listed here to ease deployment and troubleshooting.
## Next Release (replace with git tag when deployed)
* Bump runtimeVersion to `2025.04.29`.
* Upgraded stable Dart analysis SDK to `3.7.3`
* Upgraded dependencies.

## `20250424t115200-all`
* Bump runtimeVersion to `2025.04.24`.
Expand Down
2 changes: 2 additions & 0 deletions pkg/api_builder/lib/src/api_router_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// ignore_for_file: deprecated_member_use

import 'package:analyzer/dart/element/element.dart' show ClassElement;
import 'package:analyzer/dart/element/type.dart' show ParameterizedType;
import 'package:code_builder/code_builder.dart' as code;
Expand Down
2 changes: 2 additions & 0 deletions pkg/api_builder/lib/src/client_library_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// ignore_for_file: deprecated_member_use

import 'package:analyzer/dart/element/element.dart'
show ClassElement, ExecutableElement;
import 'package:analyzer/dart/element/type.dart'
Expand Down
2 changes: 2 additions & 0 deletions pkg/api_builder/lib/src/shared.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// ignore_for_file: deprecated_member_use

import 'package:analyzer/dart/element/element.dart'
show ClassElement, ExecutableElement, ParameterElement;
import 'package:analyzer/dart/element/type.dart' show DartType;
Expand Down
3 changes: 2 additions & 1 deletion pkg/web_app/lib/script.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ void _setupDarkThemeButton() {
button.onClick.listen((_) {
final classes = document.body!.classList;
final isCurrentlyDark = classes.contains('dark-theme');
window.localStorage['colorTheme'] = isCurrentlyDark ? 'false' : 'true';
window.localStorage
.setItem('colorTheme', isCurrentlyDark ? 'false' : 'true');
classes.toggle('dark-theme');
classes.toggle('light-theme');
});
Expand Down
6 changes: 3 additions & 3 deletions pkg/web_app/lib/src/hoverable.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ void _setEventForPreCodeCopyToClipboard() {

final feedback = HTMLDivElement()
..classList.add('-pub-pre-copy-feedback')
..text = 'copied to clipboard';
..textContent = 'copied to clipboard';
container.append(feedback);

_setupCopyAndFeedbackButton(
Expand Down Expand Up @@ -176,7 +176,7 @@ void _updateXAgoLabels() {
final newLabel = formatXAgo(DateTime.now().difference(timestamp));
final oldLabel = e.textContent;
if (oldLabel != newLabel) {
e.text = newLabel;
e.textContent = newLabel;
}
});
}
Expand All @@ -188,7 +188,7 @@ void _setEventForXAgo() {
event.preventDefault();
event.stopPropagation();
final text = e.textContent;
e.text = e.getAttribute('title') ?? '';
e.textContent = e.getAttribute('title') ?? '';
e.setAttribute('title', text!);
});
});
Expand Down
12 changes: 6 additions & 6 deletions pkg/web_app/lib/src/widget/downloads_chart/widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ void drawChart(
tickLabel.setAttribute(
'class', 'downloads-chart-tick-label downloads-chart-tick-label-x');
}
tickLabel.text = formatAbbrMonthDay(date);
tickLabel.textContent = formatAbbrMonthDay(date);
tickLabel.setAttribute('y', '$tickLabelYCoordinate');
tickLabel.setAttribute('x', '$x');

Expand All @@ -321,7 +321,7 @@ void drawChart(
final suffix = displayMode == DisplayMode.percentage
? '%'
: compactFormat(i * interval).suffix;
tickLabel.text = '${compactFormat(i * interval).value}$suffix';
tickLabel.textContent = '${compactFormat(i * interval).value}$suffix';
tickLabel.setAttribute('x', '${xMax + marginPadding}');
tickLabel.setAttribute('y', '$y');
chart.append(tickLabel);
Expand Down Expand Up @@ -439,7 +439,7 @@ void drawChart(

final legendLabel = SVGTextElement();
legendLabel.setAttribute('class', 'downloads-chart-tick-label');
legendLabel.text = ranges[i];
legendLabel.textContent = ranges[i];
chart.append(legendLabel);
chart.append(legend);
legends.add((legend, legendLabel));
Expand Down Expand Up @@ -629,7 +629,7 @@ void drawChart(
'top:${e.y + toolTipOffsetFromMouse + document.scrollingElement!.scrollTop}px;$horizontalPosition');
toolTip.replaceChildren(HTMLDivElement()
..setAttribute('class', 'downloads-chart-tooltip-date')
..text =
..textContent =
'${formatAbbrMonthDay(startDay)} - ${formatAbbrMonthDay(selectedDay)}');

final downloads = values[nearestIndex];
Expand All @@ -641,14 +641,14 @@ void drawChart(
final square = HTMLDivElement()
..setAttribute('class',
'downloads-chart-tooltip-square ${squareColorClass(colorIndex(i))}');
final rangeText = HTMLSpanElement()..text = '${ranges[i]}: ';
final rangeText = HTMLSpanElement()..textContent = '${ranges[i]}: ';
final suffix = (displayMode == DisplayMode.percentage)
? ' (${(downloads[i] * 100 / totals[nearestIndex]).toStringAsPrecision(2)}%)'
: '';
final text = '${formatWithThousandSeperators(downloads[i])}$suffix';
final downloadsText = HTMLSpanElement()
..setAttribute('class', 'downloads-chart-tooltip-downloads')
..text = text;
..textContent = text;

final tooltipRange = HTMLDivElement()
..setAttribute('class', 'downloads-chart-tooltip-row')
Expand Down
11 changes: 7 additions & 4 deletions pkg/web_app/lib/src/widget/weekly_sparkline/widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ void drawChart(Element svg, HTMLDivElement toolTip, HTMLDivElement chartSubText,

// Render chart

chartSubText.text = '${formatDate(firstDay)} - ${formatDate(lastDate)}';
chartSubText.textContent =
'${formatDate(firstDay)} - ${formatDate(lastDate)}';
final chart = SVGGElement();

final sparklineBar = SVGLineElement();
Expand Down Expand Up @@ -158,10 +159,11 @@ void drawChart(Element svg, HTMLDivElement toolTip, HTMLDivElement chartSubText,
final coords = computeCoordinates(selectedDay.date, selectedDay.downloads);
sparklineSpot.setAttribute('cy', '${coords.$2}');
sparklineCursor.setAttribute('transform', 'translate(${coords.$1}, 0)');
toolTip.text = '${formatWithThousandSeperators(selectedDay.downloads)}';
toolTip.textContent =
'${formatWithThousandSeperators(selectedDay.downloads)}';

final startDay = selectedDay.date.subtract(Duration(days: 7));
chartSubText.text =
chartSubText.textContent =
'${formatDate(startDay)} - ${formatDate(selectedDay.date)}';

lastSelectedDay = selectedDay.date;
Expand All @@ -170,7 +172,8 @@ void drawChart(Element svg, HTMLDivElement toolTip, HTMLDivElement chartSubText,
void hideSparklineCursor(_) {
sparklineCursor.setAttribute('style', 'opacity:0');
toolTip.setAttribute('style', 'opacity:0;position:absolute;');
chartSubText.text = '${formatDate(firstDay)} - ${formatDate(lastDate)}';
chartSubText.textContent =
'${formatDate(firstDay)} - ${formatDate(lastDate)}';
lastSelectedDay = null;
}

Expand Down
Loading