Skip to content

Use new HTTP retry logic in openid client. #8737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Use new HTTP retry logic in openid client. #8737

merged 1 commit into from
May 9, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented May 6, 2025

  • The logic is mostly unchanged, but dropping the separate client creation and closing, delegating it to the retry HTTP GET logic.
  • Since the connection is short-lived anyway, and won't be used often, I think it is ok to keep it simpler and not reuse any global connection.

@isoos isoos requested review from jonasfj and sigurdm May 6, 2025 14:56
@isoos isoos merged commit f6720dc into dart-lang:master May 9, 2025
31 checks passed
@isoos isoos deleted the http-openid branch May 9, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @sigurdm