Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jun 3, 2025

  • updated offset and limit to be non-nullable and moved range sanitization to the innermost constructor
  • extracted best name match into its own method, because it is easily separable from the rest
  • extracted predicate filtering in preparation of providing a fast-track to queries without text
  • the extracted predicate filtering also allows for an early return check where the offset of query is larger than the available item count
  • local benchmark shows no difference in performance

@isoos isoos requested a review from sigurdm June 3, 2025 09:48
@isoos isoos merged commit 8bd3274 into dart-lang:master Jun 3, 2025
31 checks passed
@isoos isoos deleted the search-refactor branch June 3, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants