Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jun 9, 2025

  • Fixes Workers fail with 401 #8799.
  • Updated the test in one commit, overlayed with the fix in another.
  • I was considering to update the worker to handle not found or the 401 better, but eventually decided to just emit TaskAborted in all of these cases. Handling the other cases wouldn't really improve the log suppression, and exposing this message wouldn't compromise us in any way against a malicious attacker (they would know that it is about expired tokens anyway).

@isoos isoos requested review from sigurdm and szakarias June 9, 2025 08:53
@isoos isoos merged commit 482b22b into dart-lang:master Jun 10, 2025
31 checks passed
@isoos isoos deleted the task-aborted branch June 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workers fail with 401

2 participants