Skip to content

Improve search isolate testing by loading an actual index. #8821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Improve search isolate testing by loading an actual index. #8821

merged 1 commit into from
Jun 16, 2025

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Jun 16, 2025

  • Improves testing by providing an actual index that will be loaded and used for verification.
  • Creates the argument-parsing logic that will be useful for another isolate-related optimization (having a predicate-only isolate for fast-tracking easy queries).

@isoos isoos requested review from sigurdm and szakarias June 16, 2025 13:19
@isoos isoos merged commit de827c6 into dart-lang:master Jun 16, 2025
31 checks passed
@isoos isoos deleted the isolate-test branch June 16, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@szakarias szakarias Awaiting requested review from szakarias

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @sigurdm