Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions app/lib/scorecard/backend.dart
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ class ScoreCardBackend {
@visibleForTesting
Future<PackageView?> getPackageView(String package) async {
return await cache.packageView(package).get(() async {
if (!await packageBackend.isPackageVisible(package)) {
return null;
}
final p = await packageBackend.lookupPackage(package);
if (p == null) {
_logger.warning('Package lookup failed for "$package".');
Expand All @@ -85,20 +88,24 @@ class ScoreCardBackend {
return null;
}

final releases = await packageBackend.latestReleases(p);
final pvFuture = packageBackend.lookupPackageVersion(package, version);
final cardFuture = scoreCardBackend.getScoreCardData(package, version);
await Future.wait([pvFuture, cardFuture]);

final pv = await pvFuture;
final card = await cardFuture;

return PackageView.fromModel(
package: p,
releases: releases,
version: pv,
scoreCard: card,
);
try {
final releases = await packageBackend.latestReleases(p);
final pvFuture = packageBackend.lookupPackageVersion(package, version);
final cardFuture = scoreCardBackend.getScoreCardData(package, version);
await Future.wait([pvFuture, cardFuture]);

final pv = await pvFuture;
final card = await cardFuture;

return PackageView.fromModel(
package: p,
releases: releases,
version: pv,
scoreCard: card,
);
} on NotFoundException catch (_) {
return null;
}
});
}

Expand Down
2 changes: 2 additions & 0 deletions app/lib/search/backend.dart
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ class SearchBackend {
snapshot.add(doc);
} on RemovedPackageException catch (_) {
snapshot.remove(package);
} on NotFoundException catch (_) {
snapshot.remove(package);
}
});
}
Expand Down