From 0439ad551024bda18bf350ce2fb0b019d6f4ab19 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 25 Aug 2025 17:43:33 +0200 Subject: [PATCH] Cleanup experimental flag: trending. --- app/lib/frontend/handlers/experimental.dart | 2 -- app/lib/frontend/templates/_consts.dart | 14 +++++--------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/app/lib/frontend/handlers/experimental.dart b/app/lib/frontend/handlers/experimental.dart index a3e476c2e8..2177c6a3b7 100644 --- a/app/lib/frontend/handlers/experimental.dart +++ b/app/lib/frontend/handlers/experimental.dart @@ -95,8 +95,6 @@ class ExperimentalFlags { bool get useSearchPost => isEnabled('search-post'); - bool get showTrending => true; - String encodedAsCookie() => _enabled.join(':'); @override diff --git a/app/lib/frontend/templates/_consts.dart b/app/lib/frontend/templates/_consts.dart index a763970b53..6872faa19b 100644 --- a/app/lib/frontend/templates/_consts.dart +++ b/app/lib/frontend/templates/_consts.dart @@ -3,7 +3,6 @@ // BSD-style license that can be found in the LICENSE file. import 'package:_pub_shared/search/tags.dart'; -import 'package:pub_dev/frontend/request_context.dart'; import '../dom/dom.dart' as d; @@ -119,16 +118,13 @@ final _sortDicts = const [ id: 'downloads', label: 'downloads', tooltip: 'Packages are sorted by their download counts.'), + SortDict( + id: 'trending', + label: 'trending', + tooltip: 'Packages are sorted by trending.'), ]; List getSortDicts(bool isSearch) { final removeId = isSearch ? 'listing_relevance' : 'search_relevance'; - return [ - ..._sortDicts.where((d) => d.id != removeId), - if (requestContext.experimentalFlags.showTrending) - SortDict( - id: 'trending', - label: 'trending', - tooltip: 'Packages are sorted by trending.'), - ]; + return _sortDicts.where((d) => d.id != removeId).toList(); }