Remove unused or unneeded members (#1728)

Author: kevmoo

lib/src/command/barback.dart

@@ -13,8 +13,6 @@ import '../io.dart';
 import '../log.dart' as log;
 import '../utils.dart';
 
-final _arrow = getSpecial('\u2192', '=>');
-
 /// The set of top level directories in the entrypoint package that are built
 /// when the user does "--all".
 final _allSourceDirectories =

lib/src/command/build.dart

@@ -15,8 +15,6 @@ import '../source/hosted.dart';
 import '../utils.dart';
 import 'barback.dart';
 
-final _arrow = getSpecial('\u2192', '=>');
-
 /// Handles the `build` pub command.
 class BuildCommand extends BarbackCommand {
   String get name => "build";

lib/src/command/lish.dart

@@ -99,12 +99,12 @@ class LishCommand extends PubCommand {
       });
     } on PubHttpException catch (error) {
       var url = error.response.request.url;
-      if (urisEqual(url, cloudStorageUrl)) {
+      if (url == cloudStorageUrl) {
         // TODO(nweiz): the response may have XML-formatted information about
         // the error. Try to parse that out once we have an easily-accessible
         // XML parser.
         fail(log.red('Failed to upload the package.'));
-      } else if (urisEqual(Uri.parse(url.origin), Uri.parse(server.origin))) {
+      } else if (Uri.parse(url.origin) == Uri.parse(server.origin)) {
         handleJsonError(error.response);
       } else {
         rethrow;

lib/src/http.dart

@@ -94,8 +94,7 @@ class _PubHttpClient extends http.BaseClient {
     // 401 responses should be handled by the OAuth2 client. It's very
     // unlikely that they'll be returned by non-OAuth2 requests. We also want
     // to pass along 400 responses from the token endpoint.
-    var tokenRequest =
-        urisEqual(streamedResponse.request.url, oauth2.tokenEndpoint);
+    var tokenRequest = streamedResponse.request.url == oauth2.tokenEndpoint;
     if (status < 400 || status == 401 || (status == 400 && tokenRequest)) {
       return streamedResponse;
     }

lib/src/utils.dart

@@ -292,33 +292,6 @@ List/*<T>*/ ordered/*<T extends Comparable<T>>*/(Iterable/*<T>*/ iter) {
   return list;
 }
 
-/// Returns the element of [iter] for which [f] returns the minimum value.
-minBy(Iterable iter, Comparable f(element)) {
-  var min = null;
-  var minComparable = null;
-  for (var element in iter) {
-    var comparable = f(element);
-    if (minComparable == null || comparable.compareTo(minComparable) < 0) {
-      min = element;
-      minComparable = comparable;
-    }
-  }
-  return min;
-}
-
-/// Returns every pair of consecutive elements in [iter].
-///
-/// For example, if [iter] is `[1, 2, 3, 4]`, this will return `[(1, 2), (2, 3),
-/// (3, 4)]`.
-Iterable<Pair> pairs(Iterable iter) {
-  var previous = iter.first;
-  return iter.skip(1).map((element) {
-    var oldPrevious = previous;
-    previous = element;
-    return new Pair(oldPrevious, element);
-  });
-}
-
 /// Given a list of filenames, returns a set of patterns that can be used to
 /// filter for those filenames.
 ///
@@ -356,15 +329,6 @@ maxAll(Iterable iter, [int compare(element1, element2)]) {
       .reduce((max, element) => compare(element, max) > 0 ? element : max);
 }
 
-/// Returns the minimum value in [iter] by [compare].
-///
-/// [compare] defaults to [Comparable.compare].
-minAll(Iterable iter, [int compare(element1, element2)]) {
-  if (compare == null) compare = Comparable.compare;
-  return iter
-      .reduce((max, element) => compare(element, max) < 0 ? element : max);
-}
-
 /// Replace each instance of [matcher] in [source] with the return value of
 /// [fn].
 String replace(String source, Pattern matcher, String fn(Match)) {
@@ -379,14 +343,6 @@ String replace(String source, Pattern matcher, String fn(Match)) {
   return buffer.toString();
 }
 
-/// Returns whether or not [str] ends with [matcher].
-bool endsWithPattern(String str, Pattern matcher) {
-  for (var match in matcher.allMatches(str)) {
-    if (match.end == str.length) return true;
-  }
-  return false;
-}
-
 /// Returns the hex-encoded sha1 hash of [source].
 String sha1(String source) =>
     crypto.sha1.convert(UTF8.encode(source)).toString();
@@ -484,17 +440,6 @@ Future streamFirst(Stream stream) {
   return completer.future;
 }
 
-/// Returns a wrapped version of [stream] along with a [StreamSubscription] that
-/// can be used to control the wrapped stream.
-Pair<Stream, StreamSubscription> streamWithSubscription(Stream stream) {
-  var controller = stream.isBroadcast
-      ? new StreamController.broadcast(sync: true)
-      : new StreamController(sync: true);
-  var subscription = stream.listen(controller.add,
-      onError: controller.addError, onDone: controller.close);
-  return new Pair<Stream, StreamSubscription>(controller.stream, subscription);
-}
-
 /// A regular expression matching a trailing CR character.
 final _trailingCR = new RegExp(r"\r$");
 
@@ -530,19 +475,6 @@ Stream<String> streamToLines(Stream<String> stream) {
   }));
 }
 
-/// Like [Iterable.where], but allows [test] to return [Future]s and uses the
-/// results of those [Future]s as the test.
-Future<Iterable> futureWhere(Iterable iter, test(value)) {
-  return Future
-      .wait(iter.map((e) {
-        var result = test(e);
-        if (result is! Future) result = new Future.value(result);
-        return result.then((result) => new Pair(e, result));
-      }))
-      .then((pairs) => pairs.where((pair) => pair.last))
-      .then((pairs) => pairs.map((pair) => pair.first));
-}
-
 // TODO(nweiz): unify the following functions with the utility functions in
 // pkg/http.
 
@@ -602,19 +534,6 @@ String mapToQuery(Map<String, String> map) {
 Set/*<T>*/ unionAll/*<T>*/(Iterable<Set/*<T>*/ > sets) =>
     sets.fold(new Set(), (union, set) => union.union(set));
 
-// TODO(nweiz): remove this when issue 9068 has been fixed.
-/// Whether [uri1] and [uri2] are equal.
-///
-/// This consider HTTP URIs to default to port 80, and HTTPs URIs to default to
-/// port 443.
-bool urisEqual(Uri uri1, Uri uri2) =>
-    canonicalizeUri(uri1) == canonicalizeUri(uri2);
-
-/// Return [uri] with redundant port information removed.
-Uri canonicalizeUri(Uri uri) {
-  return uri;
-}
-
 /// Returns a human-friendly representation of [inputPath].
 ///
 /// If [inputPath] isn't too distant from the current working directory, this

test/test_pub.dart

@@ -74,9 +74,6 @@ final String packagesPath = "$appPath/packages";
 /// to the sandbox directory.
 final String packagesFilePath = "$appPath/.packages";
 
-/// Set to true when the current batch of scheduled events should be aborted.
-bool _abortScheduled = false;
-
 /// Enum identifying a pub command that can be run with a well-defined success
 /// output.
 class RunCommand {