Emit exit code 66 for missing path dependencies (#1748)

Emit exit code 66 for missing path dependencies

Closes #1747

Author: nex3

lib/src/command_runner.dart

@@ -30,7 +30,6 @@ import 'http.dart';
 import 'io.dart';
 import 'log.dart' as log;
 import 'sdk.dart' as sdk;
-import 'solver/version_solver.dart';
 import 'utils.dart';
 
 class PubCommandRunner extends CommandRunner {
@@ -230,15 +229,20 @@ and include the logs in an issue on https://github.com/dart-lang/pub/issues/new
   /// Returns the appropriate exit code for [exception], falling back on 1 if no
   /// appropriate exit code could be found.
   int _chooseExitCode(exception) {
-    while (exception is WrappedException) exception = exception.innerError;
+    while (exception is WrappedException && exception.innerError is Exception) {
+      exception = exception.innerError;
+    }
 
     if (exception is HttpException ||
         exception is http.ClientException ||
         exception is SocketException ||
         exception is TlsException ||
         exception is PubHttpException ||
-        exception is DependencyNotFoundException) {
+        exception is git.GitException ||
+        exception is PackageNotFoundException) {
       return exit_codes.UNAVAILABLE;
+    } else if (exception is FileSystemException || exception is FileException) {
+      return exit_codes.NO_INPUT;
     } else if (exception is FormatException || exception is DataException) {
       return exit_codes.DATA;
     } else if (exception is UsageException) {

lib/src/solver/version_solver.dart

@@ -469,12 +469,15 @@ class DescriptionMismatchException extends SolveFailure {
 ///
 /// Unlike [PackageNotFoundException], this includes information about the
 /// dependent packages requesting the missing one.
-class DependencyNotFoundException extends SolveFailure {
-  final PackageNotFoundException _innerException;
-  String get _message => "${_innerException.message}\nDepended on by";
+class DependencyNotFoundException extends SolveFailure
+    implements WrappedException {
+  final PackageNotFoundException innerError;
+  Chain get innerChain => innerError.innerChain;
+
+  String get _message => "${innerError.message}\nDepended on by";
 
   DependencyNotFoundException(
-      String package, this._innerException, Iterable<Dependency> dependencies)
+      String package, this.innerError, Iterable<Dependency> dependencies)
       : super(package, dependencies);
 
   /// The failure isn't because of the version of description of the package,

lib/src/source/path.dart

@@ -175,6 +175,7 @@ class BoundPathSource extends BoundSource {
     }
 
     throw new PackageNotFoundException(
-        'Could not find package $name at "$dir".');
+        'Could not find package $name at "$dir".',
+        new FileException('$dir does not exist.', dir));
   }
 }

test/get/path/no_pubspec_test.dart

@@ -5,6 +5,7 @@
 import 'package:test/test.dart';
 
 import 'package:path/path.dart' as path;
+import 'package:pub/src/exit_codes.dart' as exit_codes;
 
 import '../../descriptor.dart' as d;
 import '../../test_pub.dart';
@@ -23,6 +24,7 @@ main() {
 
     await pubGet(
         error: new RegExp(r'Could not find a file named "pubspec.yaml" '
-            r'in "[^\n]*"\.'));
+            r'in "[^\n]*"\.'),
+        exitCode: exit_codes.NO_INPUT);
   });
 }

test/get/path/nonexistent_dir_test.dart

@@ -23,6 +23,6 @@ main() {
     await pubGet(error: """
         Could not find package foo at "$badPath".
         Depended on by:
-        - myapp""", exitCode: exit_codes.UNAVAILABLE);
+        - myapp""", exitCode: exit_codes.NO_INPUT);
   });
 }

test/global/activate/missing_git_repo_test.dart

@@ -4,6 +4,8 @@
 
 import 'package:test/test.dart';
 
+import 'package:pub/src/exit_codes.dart' as exit_codes;
+
 import '../../test_pub.dart';
 
 main() {
@@ -13,6 +15,6 @@ main() {
     await runPub(
         args: ["global", "activate", "-sgit", "../nope.git"],
         error: contains("repository '../nope.git' does not exist"),
-        exitCode: 1);
+        exitCode: exit_codes.UNAVAILABLE);
   });
 }

test/global/run/missing_path_package_test.dart

@@ -5,6 +5,7 @@
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
 
+import 'package:pub/src/exit_codes.dart' as exit_codes;
 import 'package:pub/src/io.dart';
 
 import '../../descriptor.dart' as d;
@@ -25,6 +26,6 @@ main() {
     var path = canonicalize(p.join(d.sandbox, "foo"));
     expect(pub.stderr,
         emits('Could not find a file named "pubspec.yaml" in "$path".'));
-    await pub.shouldExit(1);
+    await pub.shouldExit(exit_codes.NO_INPUT);
   });
 }

test/list_package_dirs/missing_pubspec_test.dart

@@ -2,9 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE d.file.
 
+import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
-import 'package:path/path.dart' as path;
+import 'package:pub/src/exit_codes.dart' as exit_codes;
 import 'package:pub/src/io.dart';
 
 import '../descriptor.dart' as d;
@@ -22,6 +23,6 @@ main() {
       "error": 'Could not find a file named "pubspec.yaml" in "'
           '${canonicalize(path.join(d.sandbox, appPath))}".',
       "path": canonicalize(path.join(d.sandbox, appPath, "pubspec.yaml"))
-    }, exitCode: 1);
+    }, exitCode: exit_codes.NO_INPUT);
   });
 }

test/pub_get_and_upgrade_test.dart

@@ -17,7 +17,8 @@ main() {
 
         await pubCommand(command,
             error: new RegExp(r'Could not find a file named "pubspec.yaml" '
-                r'in "[^\n]*"\.'));
+                r'in "[^\n]*"\.'),
+            exitCode: exit_codes.NO_INPUT);
       });
 
       test('a pubspec with a "name" key', () async {