require an upper bound on the sdk to publish (#1701)

Author: jakemac53

lib/src/validator/sdk_constraint.dart

@@ -20,15 +20,25 @@ class SdkConstraintValidator extends Validator {
 
   Future validate() async {
     var dartConstraint = entrypoint.root.pubspec.dartSdkConstraint;
-    if (dartConstraint is VersionRange &&
-        dartConstraint.toString().startsWith("^")) {
-      errors
-          .add("^ version constraints aren't allowed for SDK constraints since "
-              "older versions of pub don't support them.\n"
-              "Expand it manually instead:\n"
-              "\n"
-              "environment:\n"
-              "  sdk: \">=${dartConstraint.min} <${dartConstraint.max}\"");
+    if (dartConstraint is VersionRange) {
+      if (dartConstraint.toString().startsWith("^")) {
+        errors.add(
+            "^ version constraints aren't allowed for SDK constraints since "
+            "older versions of pub don't support them.\n"
+            "Expand it manually instead:\n"
+            "\n"
+            "environment:\n"
+            "  sdk: \">=${dartConstraint.min} <${dartConstraint.max}\"");
+      }
+
+      if (dartConstraint.max == null) {
+        errors.add(
+            'Published packages should have an upper bound constraint on the '
+            'Dart SDK (typically this should restrict to less than the next '
+            'major version to guard against breaking changes).\n'
+            'See https://www.dartlang.org/tools/pub/pubspec#sdk-constraints for '
+            'instructions on setting an sdk version constraint.');
+      }
     }
 
     if (entrypoint.root.pubspec.flutterSdkConstraint != null &&

test/descriptor.dart

@@ -28,7 +28,7 @@ TarFileDescriptor tar(String name, [Iterable<Descriptor> contents]) =>
 
 /// Describes a package that passes all validation.
 Descriptor get validPackage => dir(appPath, [
-      libPubspec("test_pkg", "1.0.0"),
+      libPubspec("test_pkg", "1.0.0", sdk: '>=1.8.0 <=2.0.0'),
       file("LICENSE", "Eh, do what you want."),
       dir("lib", [file("test_pkg.dart", "int i = 1;")])
     ]);

test/lish/force_does_not_publish_if_there_are_errors_test.dart

@@ -24,7 +24,7 @@ main() {
     await pub.shouldExit(exit_codes.DATA);
     expect(
         pub.stderr,
-        emitsThrough("Sorry, your package is missing a "
-            "requirement and can't be published yet."));
+        emitsThrough("Sorry, your package is missing some "
+            "requirements and can't be published yet."));
   });
 }

test/lish/force_publishes_if_there_are_warnings_test.dart

@@ -18,7 +18,8 @@ main() {
   setUp(d.validPackage.create);
 
   test('--force publishes if there are warnings', () async {
-    var pkg = packageMap("test_pkg", "1.0.0");
+    var pkg =
+        packageMap("test_pkg", "1.0.0", null, null, {'sdk': '>=1.8.0 <2.0.0'});
     pkg["author"] = "Natalie Weizenbaum";
     await d.dir(appPath, [d.pubspec(pkg)]).create();
 

test/lish/package_validation_has_a_warning_and_continues_test.dart

@@ -18,7 +18,8 @@ main() {
   setUp(d.validPackage.create);
 
   test('package validation has a warning and continues', () async {
-    var pkg = packageMap("test_pkg", "1.0.0");
+    var pkg =
+        packageMap("test_pkg", "1.0.0", null, null, {'sdk': '>=1.8.0 <2.0.0'});
     pkg["author"] = "Natalie Weizenbaum";
     await d.dir(appPath, [d.pubspec(pkg)]).create();
 

test/lish/package_validation_has_a_warning_and_is_canceled_test.dart

@@ -14,7 +14,8 @@ main() {
   setUp(d.validPackage.create);
 
   test('package validation has a warning and is canceled', () async {
-    var pkg = packageMap("test_pkg", "1.0.0");
+    var pkg =
+        packageMap("test_pkg", "1.0.0", null, null, {'sdk': '>=1.8.0 <2.0.0'});
     pkg["author"] = "Natalie Weizenbaum";
     await d.dir(appPath, [d.pubspec(pkg)]).create();
 

test/lish/package_validation_has_an_error_test.dart

@@ -24,7 +24,7 @@ main() {
     await pub.shouldExit(exit_codes.DATA);
     expect(
         pub.stderr,
-        emitsThrough("Sorry, your package is missing a "
-            "requirement and can't be published yet."));
+        emitsThrough("Sorry, your package is missing some "
+            "requirements and can't be published yet."));
   });
 }

test/lish/preview_package_validation_has_a_warning_test.dart

@@ -14,7 +14,8 @@ main() {
   setUp(d.validPackage.create);
 
   test('preview package validation has a warning', () async {
-    var pkg = packageMap("test_pkg", "1.0.0");
+    var pkg =
+        packageMap("test_pkg", "1.0.0", null, null, {'sdk': '>=1.8.0 <2.0.0'});
     pkg["author"] = "Natalie Weizenbaum";
     await d.dir(appPath, [d.pubspec(pkg)]).create();
 

test/lish/preview_package_validation_has_no_warnings_test.dart

@@ -14,7 +14,8 @@ main() {
   setUp(d.validPackage.create);
 
   test('preview package validation has no warnings', () async {
-    var pkg = packageMap("test_pkg", "1.0.0");
+    var pkg =
+        packageMap("test_pkg", "1.0.0", null, null, {'sdk': '>=1.8.0 <2.0.0'});
     pkg["author"] = "Natalie Weizenbaum <[email protected]>";
     await d.dir(appPath, [d.pubspec(pkg)]).create();
 

test/test_pub.dart

@@ -591,6 +591,7 @@ Map packageMap(
   String version, [
   Map dependencies,
   Map devDependencies,
+  Map environment,
 ]) {
   var package = <String, dynamic>{
     "name": name,
@@ -602,6 +603,7 @@ Map packageMap(
 
   if (dependencies != null) package["dependencies"] = dependencies;
   if (devDependencies != null) package["dev_dependencies"] = devDependencies;
+  if (environment != null) package["environment"] = environment;
   return package;
 }