Skip to content

Commit f5cbc08

Browse files
authored
Fix a flake caused by long dart2js compilation (#1774)
Closes #1773
1 parent 667281e commit f5cbc08

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

test/test_pub.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,12 @@ void _validateOutputJson(
728728
failures.add(actualText);
729729
}
730730

731+
// Remove dart2js's timing logs, which would otherwise cause tests to fail
732+
// flakily when compilation takes a long time.
733+
actual['log']?.removeWhere((entry) =>
734+
entry['level'] == 'Fine' &&
735+
entry['message'].startsWith('Not yet complete after'));
736+
731737
// Match against the expectation.
732738
expect(actual, expected);
733739
}

0 commit comments

Comments
 (0)