[cfe] Remove nnbd mode

TEST=existing

Change-Id: I30bbadb74e81c7f4aaa444d1e2f6f5ffc2005d4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412881
Reviewed-by: Jens Johansen <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>

Author: johnniwinther

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -1491,18 +1491,6 @@ Message _withArgumentsCombinedMemberSignatureFailed(String name, String name2) {
   );
 }
 
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Null> codeCompilingWithoutSoundNullSafety =
-    messageCompilingWithoutSoundNullSafety;
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageCompilingWithoutSoundNullSafety = const MessageCode(
-  "CompilingWithoutSoundNullSafety",
-  severity: Severity.info,
-  problemMessage: r"""Compiling without sound null safety!
-Dart 3 will only support sound null safety, see https://dart.dev/null-safety""",
-);
-
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(String string, String string2)>
     templateConflictingModifiers =

pkg/compiler/lib/src/ir/constants.dart

@@ -19,7 +19,6 @@ class Dart2jsConstantEvaluator extends ir.TryConstantEvaluator {
     ir.ReportErrorFunction reportError, {
     Environment? environment,
     super.supportReevaluationForTesting,
-    required super.evaluationMode,
   }) : super(
          const Dart2jsDartLibrarySupport(),
          const Dart2jsConstantsBackend(supportsUnevaluatedConstants: false),

pkg/compiler/lib/src/phase/load_kernel.dart

@@ -164,10 +164,6 @@ void _simplifyConstConditionals(
     reportMessage,
     environmentDefines: options.environment,
     classHierarchy: classHierarchy,
-    evaluationMode:
-        options.useLegacySubtyping
-            ? fe.EvaluationMode.weak
-            : fe.EvaluationMode.strong,
     shouldNotInline: shouldNotInline,
     removeAsserts: !options.enableUserAssertions,
   ).run();
@@ -198,10 +194,6 @@ void _doTransformsOnKernelLoad(
       (fe.LocatedMessage message, List<fe.LocatedMessage>? context) =>
           reportLocatedMessage(reporter, message, context),
       environment: Environment(options.environment),
-      evaluationMode:
-          options.useLegacySubtyping
-              ? fe.EvaluationMode.weak
-              : fe.EvaluationMode.strong,
     );
     StaticInteropClassEraser(coreTypes).visitComponent(component);
     global_transforms.transformLibraries(
@@ -347,8 +339,6 @@ Future<_LoadFromSourceResult> _loadFromSource(
     options.packageConfig,
     explicitExperimentalFlags: options.explicitExperimentalFlags,
     environmentDefines: environment,
-    nnbdMode:
-        options.useLegacySubtyping ? fe.NnbdMode.Weak : fe.NnbdMode.Strong,
     invocationModes: options.cfeInvocationModes,
     verbosity: verbosity,
   );

pkg/compiler/test/end_to_end/dill_loader_test.dart

@@ -29,7 +29,6 @@ main() {
     var options =
         CompilerOptions()
           ..target = Dart2jsTarget("dart2js", TargetFlags())
-          ..nnbdMode = NnbdMode.Strong
           ..packagesFileUri = Uri.base.resolve('.dart_tool/package_config.json')
           ..additionalDills = <Uri>[
             computePlatformBinariesLocation().resolve("dart2js_platform.dill"),

pkg/compiler/test/end_to_end/modular_loader_test.dart

@@ -115,7 +115,6 @@ Future<Uint8List> compileUnit(
       CompilerOptions()
         ..target = Dart2jsTarget("dart2js", TargetFlags())
         ..fileSystem = TestFileSystem(fs)
-        ..nnbdMode = NnbdMode.Strong
         ..additionalDills = additionalDills
         ..packagesFileUri = toTestUri('.dart_tool/package_config.json')
         ..explicitExperimentalFlags = {ExperimentalFlag.nonNullable: true};

pkg/compiler/test/model/cfe_constant_evaluation_common.dart

@@ -904,10 +904,6 @@ Future<void> runEnvTest(
         },
         environment: Environment(env),
         supportReevaluationForTesting: true,
-        evaluationMode:
-            compiler.options.useLegacySubtyping
-                ? ir.EvaluationMode.weak
-                : ir.EvaluationMode.strong,
       );
       ir.Constant evaluatedConstant = evaluator.evaluate(
         ir.StaticTypeContext(node, typeEnvironment),

pkg/dart2wasm/lib/compile.dart

@@ -15,7 +15,6 @@ import 'package:front_end/src/api_unstable/vm.dart'
         CompilerResult,
         DiagnosticMessage,
         kernelForProgram,
-        NnbdMode,
         Severity;
 import 'package:kernel/ast.dart';
 import 'package:kernel/class_hierarchy.dart';
@@ -136,8 +135,7 @@ Future<CompilationResult> compileToModule(
     }
     ..explicitExperimentalFlags = options.feExperimentalFlags
     ..verbose = false
-    ..onDiagnostic = diagnosticMessageHandler
-    ..nnbdMode = NnbdMode.Strong;
+    ..onDiagnostic = diagnosticMessageHandler;
   if (options.multiRootScheme != null) {
     compilerOptions.fileSystem = MultiRootFileSystem(
         options.multiRootScheme!,

pkg/dart2wasm/lib/constant_evaluator.dart

@@ -50,7 +50,6 @@ class ConstantEvaluator extends kernel.ConstantEvaluator
           enableTripleShift: true,
           enableAsserts: options.translatorOptions.enableAsserts,
           errorOnUnevaluatedConstant: true,
-          evaluationMode: kernel.EvaluationMode.strong,
         );
 
   @override

pkg/dart2wasm/lib/target.dart

@@ -10,7 +10,7 @@ import 'package:_js_interop_checks/src/transformations/shared_interop_transforme
 import 'package:front_end/src/api_prototype/const_conditional_simplifier.dart'
     show ConstConditionalSimplifier;
 import 'package:front_end/src/api_prototype/constant_evaluator.dart'
-    as constantEvaluator show ConstantEvaluator, EvaluationMode;
+    as constantEvaluator show ConstantEvaluator;
 import 'package:kernel/ast.dart';
 import 'package:kernel/class_hierarchy.dart';
 import 'package:kernel/clone.dart';
@@ -320,7 +320,6 @@ class WasmTarget extends Target {
         component,
         reportError,
         environmentDefines: environmentDefines,
-        evaluationMode: constantEvaluator.EvaluationMode.strong,
         coreTypes: coreTypes,
         classHierarchy: hierarchy,
         removeAsserts: removeAsserts,

pkg/dev_compiler/lib/src/command/command.dart

@@ -292,9 +292,7 @@ Future<CompilerResult> _compile(List<String> args,
             soundNullSafety: options.soundNullSafety)),
         fileSystem: fileSystem,
         explicitExperimentalFlags: explicitExperimentalFlags,
-        environmentDefines: declaredVariables,
-        nnbdMode:
-            options.soundNullSafety ? fe.NnbdMode.Strong : fe.NnbdMode.Weak);
+        environmentDefines: declaredVariables);
     result = await fe.compile(compilerState, inputs, diagnosticMessageHandler);
   } else {
     // If digests weren't given and if not in worker mode, create fake data and
@@ -334,9 +332,7 @@ Future<CompilerResult> _compile(List<String> args,
         fileSystem: fileSystem,
         explicitExperimentalFlags: explicitExperimentalFlags,
         environmentDefines: declaredVariables,
-        trackNeededDillLibraries: recordUsedInputs,
-        nnbdMode:
-            options.soundNullSafety ? fe.NnbdMode.Strong : fe.NnbdMode.Weak);
+        trackNeededDillLibraries: recordUsedInputs);
     var incrementalCompiler = compilerState.incrementalCompiler!;
     var cachedSdkInput = compileSdk
         ? null