Only mark tests non-text if they actually depend on line ending.

Some test files were included, where only their data actually
depended on line endings.

Some tests didn't actually depend on line ending at all.
(They may date back to a time where multiline strings didn't
normalize their newlines.)

Fix some syntax tests that had been formatted, and exempt
all files depending on line endings from formatting.

Change-Id: I6c003e9c4f03d3b2af102bfca59d4a7bc8e6d63f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434380
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Lasse Nielsen <[email protected]>

Author: lrhn

.gitattributes

@@ -16,20 +16,13 @@
 
 # File that should not be converted.
 tests/web/eof_line_ending_test.dart -text
-tests/web/string_interpolation_test.dart -text
-tests/web/string_interpolation_dynamic_test.dart -text
-tests/web/literal_string_juxtaposition_test.dart -text
-tests/language/string/raw_string_test.dart -text
-tests/language/string/multiline_strings_test.dart -text
 tests/language/string/multiline_newline_cr.dart -text
 tests/language/string/multiline_newline_crlf.dart -text
 tests/language/string/multiline_newline_lf.dart -text
 tests/lib/mirrors/method_mirror_source_line_ending_cr.dart -text
 tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart -text
 tests/lib/mirrors/method_mirror_source_line_ending_lf.dart -text
-tests/lib/mirrors/method_mirror_source_line_ending_test.dart -text
 tests/lib/mirrors/method_mirror_source_other.dart -text
-tests/lib/mirrors/method_mirror_source_test.dart -text
 
 # Files to leave alone and not diff.
 *.png binary

tests/language/string/multiline_newline_cr.dart

@@ -2,24 +2,16 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library multiline_newline_cr;
+// Test depends on specific line endings,
+// and requires an entry in the .gitattributes file.
 
-const constantMultilineString = """
-a
-b
-""";
+// dart format off
 
-var nonConstantMultilineString = """
-a
-b
-""";
+// All line endings inside string literals are Carriage Return, U+000D
+const constantMultilineString = """ab""";
 
-const constantRawMultilineString = r"""
-\a
-\b
-""";
+var nonConstantMultilineString = """ab""";
 
-var nonConstantRawMultilineString = r"""
-\a
-\b
-""";
+const constantRawMultilineString = r"""\a\b""";
+
+var nonConstantRawMultilineString = r"""\a\b""";

tests/language/string/multiline_strings_test.dart

@@ -2,24 +2,29 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// Note: This test relies on LF line endings in the source file.
-
 import "package:expect/expect.dart";
 
-main() {
+void main() {
+  // Spaces after '''.
   Expect.equals('foo', '''  
 foo''');
 
+  // Tab characters after '''.
+  Expect.equals('foo', '''		
+foo''');
+
   Expect.equals('\\\nfoo', '''\\
 foo''');
 
   Expect.equals('\t\nfoo', '''\t
 foo''');
 
+  // Backslash just before newline.
   Expect.equals('foo', '''\
 foo''');
 
-  Expect.equals('foo', '''\ \
+  // Backslash before space, tab and newline.
+  Expect.equals('foo', '''\ \	\
 foo''');
 
   Expect.equals(' \nfoo', '''\x20
@@ -29,18 +34,25 @@ foo''');
   Expect.equals(' \nfoo', '''$x
 foo''');
 
+  /// Spaces after '''.
   Expect.equals('foo', r'''  
 foo''');
 
+  /// Tab characters after '''.
+  Expect.equals('foo', r'''		
+foo''');
+
   Expect.equals('\\\\\nfoo', r'''\\
 foo''');
 
   Expect.equals('\\t\nfoo', r'''\t
 foo''');
 
+  // Backslash before newline.
   Expect.equals('foo', r'''\
 foo''');
 
-  Expect.equals('foo', r'''\ \
+  // Backslash before space, tab and newline.
+  Expect.equals('foo', r'''\ \	\
 foo''');
 }

tests/language/string/raw_string_test.dart

@@ -2,48 +2,40 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// Note: This test relies on LF line endings in the source file.
-
 import "package:expect/expect.dart";
 
-class RawStringTest {
-  static testMain() {
-    Expect.equals("abcd", r"abcd");
-    Expect.equals("", r"");
-    Expect.equals("", r'');
-    Expect.equals("", r"""""");
-    Expect.equals("", r'''''');
-    Expect.equals("''''", r"''''");
-    Expect.equals('""""', r'""""');
-    Expect.equals("1\n2\n3", r"""1
+void main() {
+  Expect.equals("abcd", r"abcd");
+  Expect.equals("", r"");
+  Expect.equals("", r'');
+  Expect.equals("", r"""""");
+  Expect.equals("", r'''''');
+  Expect.equals("''''", r"''''");
+  Expect.equals('""""', r'""""');
+  Expect.equals("1\n2\n3", r"""1
 2
 3""");
-    Expect.equals("1\n2\n3", r'''1
+  Expect.equals("1\n2\n3", r'''1
 2
 3''');
-    Expect.equals("1", r"""
+  Expect.equals("1", r"""
 1""");
-    Expect.equals("1", r'''
+  Expect.equals("1", r'''
 1''');
-    Expect.equals("'", r"'");
-    Expect.equals('"', r'"');
-    Expect.equals("1", r"1");
-    Expect.equals("1", r"1");
-    Expect.equals("\$", r"$");
-    Expect.equals("\\", r"\");
-    Expect.equals("\\", r'\');
-    Expect.equals("\${12}", r"${12}");
-    Expect.equals(
-      "\\a\\b\\c\\d\\e\\f\\g\\h\\i\\j\\k\\l\\m",
-      r"\a\b\c\d\e\f\g\h\i\j\k\l\m",
-    );
-    Expect.equals(
-      "\\n\\o\\p\\q\\r\\s\\t\\u\\v\\w\\x\\y\\z",
-      r"\n\o\p\q\r\s\t\u\v\w\x\y\z",
-    );
-  }
-}
-
-main() {
-  RawStringTest.testMain();
+  Expect.equals("'", r"'");
+  Expect.equals('"', r'"');
+  Expect.equals("1", r"1");
+  Expect.equals("1", r"1");
+  Expect.equals("\$", r"$");
+  Expect.equals("\\", r"\");
+  Expect.equals("\\", r'\');
+  Expect.equals("\${12}", r"${12}");
+  Expect.equals(
+    "\\a\\b\\c\\d\\e\\f\\g\\h\\i\\j\\k\\l\\m",
+    r"\a\b\c\d\e\f\g\h\i\j\k\l\m",
+  );
+  Expect.equals(
+    "\\n\\o\\p\\q\\r\\s\\t\\u\\v\\w\\x\\y\\z",
+    r"\n\o\p\q\r\s\t\u\v\w\x\y\z",
+  );
 }