analyzer: Remove deprecated LintRule.details

Change-Id: Iaca19cddaf09759579bccd2aaee73e731a377638
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391480
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/lint/linter.dart

@@ -204,14 +204,6 @@ abstract class LintRule {
   /// visiting nodes.
   late ErrorReporter _reporter;
 
-  /// Description (in markdown format) suitable for display in a detailed lint
-  /// description.
-  ///
-  /// This property is deprecated and will be removed in a future release.
-  @Deprecated('Use .description for a short description and consider placing '
-      'long-form documentation on an external website.')
-  final String details;
-
   /// Short description suitable for display in console output.
   final String description;
 
@@ -230,9 +222,6 @@ abstract class LintRule {
     @Deprecated('Lint rule categories are no longer used. Remove the argument.')
     this.categories = const <String>{},
     required this.description,
-    @Deprecated("Specify 'details' for a short description and consider "
-        'placing long-form documentation on an external website.')
-    this.details = '',
     State? state,
   }) : state = state ?? State.stable();
 

pkg/linter/test/validate_rule_description_format_test.dart

@@ -2,23 +2,12 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: deprecated_member_use
-
 import 'package:analyzer/src/lint/registry.dart';
 import 'package:test/test.dart';
 
 import 'util/test_utils.dart';
 
 void main() {
-  const keywords = [
-    'GOOD',
-    'BAD',
-    'NOTE',
-    'DEPRECATED',
-    'EXCEPTION',
-    'EXCEPTIONS',
-  ];
-
   group('rule doc format', () {
     setUp(setUpSharedTestEnvironment);
 
@@ -38,75 +27,5 @@ void main() {
         });
       }
     });
-
-    group('details - no leading whitespace', () {
-      for (var rule in rules) {
-        test('`${rule.name}` details', () {
-          expect(rule.details.startsWith(RegExp(r'\s+')), isFalse,
-              reason:
-                  'Rule details for ${rule.name} should not have leading whitespace.');
-        });
-      }
-    });
-
-    group('details - bad first', () {
-      for (var rule in rules) {
-        test('`${rule.name}` bad example first', () {
-          var details = rule.details;
-          var lines = details.split('\n');
-          var hasGood = false;
-          for (var line in lines) {
-            if (line.startsWith('**BAD:**')) {
-              if (hasGood) {
-                fail(
-                    'Rule details for ${rule.name} should have the BAD example before the GOOD one.');
-              }
-              break;
-            } else if (line.startsWith('**GOOD:**')) {
-              hasGood = true;
-            }
-          }
-        });
-      }
-    });
-
-    group('details - colon inside stars', () {
-      for (var rule in rules) {
-        test('`${rule.name}` colon inside stars', () {
-          var details = rule.details;
-          var lines = details.split('\n');
-
-          for (var line in lines) {
-            for (var keyword in keywords) {
-              var withStars = '**$keyword**';
-              if (line.contains(withStars)) {
-                fail(
-                    'Rule details for ${rule.name} should have **$keyword:**, put the colon inside the stars.');
-              }
-            }
-          }
-        });
-      }
-    });
-
-    group('details - upper case keywords', () {
-      for (var rule in rules) {
-        test('`${rule.name}` upper case keywords', () {
-          var details = rule.details;
-          var lines = details.split('\n');
-
-          for (var line in lines) {
-            for (var keyword in keywords) {
-              var withStars = '**$keyword:**';
-              if (line.toLowerCase().contains(withStars.toLowerCase()) &&
-                  !line.contains(withStars)) {
-                fail(
-                    'Rule details for ${rule.name} should have $withStars in upper case.');
-              }
-            }
-          }
-        });
-      }
-    });
   });
 }