Elements. Rename XyzMember into SubstitutedXyzElementImpl.

New names better represent what these classes are.

The `element_printer.dart` utility is updated to produce the old `*Member` names for the new `Substituted*ElementImpl` classes. This is a temporary measure to avoid updating a large number of test expectations in this CL. The expectations will be updated and the temporary code in `element_printer.dart` will be removed in a follow-up CL.

Change-Id: Ic203600d6c1a0b686323df8bd2f8f086769309ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442721
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart

@@ -1131,7 +1131,10 @@ class DeclarationHelper {
             continue;
           }
           // Exclude static methods when completion on an instance.
-          var member = ExecutableMember.from(rawMember, substitution);
+          var member = SubstitutedExecutableElementImpl.from(
+            rawMember,
+            substitution,
+          );
           _suggestMethod(
             method: member as MethodElement,
             referencingInterface: referencingInterface,
@@ -1141,7 +1144,10 @@ class DeclarationHelper {
         }
       } else if (rawMember is GetterElement) {
         if (!excludedGetters.contains(entry.key)) {
-          var member = ExecutableMember.from(rawMember, substitution);
+          var member = SubstitutedExecutableElementImpl.from(
+            rawMember,
+            substitution,
+          );
           _suggestProperty(
             accessor: member as PropertyAccessorElement,
             referencingInterface: referencingInterface,
@@ -1151,7 +1157,10 @@ class DeclarationHelper {
         }
       } else if (rawMember is SetterElement) {
         if (includeSetters) {
-          var member = ExecutableMember.from(rawMember, substitution);
+          var member = SubstitutedExecutableElementImpl.from(
+            rawMember,
+            substitution,
+          );
           _suggestProperty(
             accessor: member as PropertyAccessorElement,
             referencingInterface: referencingInterface,

pkg/analyzer/lib/dart/element/element.dart

@@ -568,15 +568,15 @@ abstract class DirectiveUriWithUnit extends DirectiveUriWithSource {
 ///
 /// Clients may not extend, implement or mix-in this class.
 abstract class Element {
-  /// The non-[Member] version of this element.
+  /// The non-[SubstitutedElementImpl] version of this element.
   ///
   /// If the receiver is a view on an element, such as a method from an
   /// interface type with substituted type parameters, this getter will return
   /// the corresponding element from the class, without any substitutions.
   ///
-  /// If the receiver is already a non-[Member] element (or a synthetic element,
-  /// such as a synthetic property accessor), this getter will return the
-  /// receiver.
+  /// If the receiver is already a non-[SubstitutedElementImpl] element (or a
+  /// synthetic element, such as a synthetic property accessor), this getter
+  /// will return the receiver.
   Element get baseElement;
 
   /// The children of this element.

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -3221,7 +3221,10 @@ class _InstanceCreationEvaluator {
         var baseElement = initializer.element;
         if (baseElement != null && baseElement.isConst) {
           // Instantiate the constructor with the in-scope type arguments.
-          var constructor = ConstructorMember.from2(baseElement, definingType);
+          var constructor = SubstitutedConstructorElementImpl.from2(
+            baseElement,
+            definingType,
+          );
           var result = _evaluationEngine.evaluateConstructorCall(
             _library,
             _errorNode,

pkg/analyzer/lib/src/dart/element/inheritance_manager3.dart

@@ -256,7 +256,7 @@ class InheritanceManager3 {
     }
 
     var substitution = Substitution.fromInterfaceType(type);
-    return ExecutableMember.from(rawElement, substitution);
+    return SubstitutedExecutableElementImpl.from(rawElement, substitution);
   }
 
   /// Return all members of mixins, superclasses, and interfaces that a member
@@ -287,7 +287,10 @@ class InheritanceManager3 {
       var name = entry.key;
       var candidate = entry.value;
 
-      candidate = ExecutableMember.from(candidate, substitution);
+      candidate = SubstitutedExecutableElementImpl.from(
+        candidate,
+        substitution,
+      );
 
       var candidates = namedCandidates[name];
       if (candidates == null) {
@@ -336,7 +339,10 @@ class InheritanceManager3 {
         continue;
       }
 
-      executable = ExecutableMember.from(executable, substitution);
+      executable = SubstitutedExecutableElementImpl.from(
+        executable,
+        substitution,
+      );
 
       implemented[entry.key] = executable;
     }
@@ -497,7 +503,10 @@ class InheritanceManager3 {
 
       for (var entry in superTypeInterface.implemented.entries) {
         var executable = entry.value;
-        executable = ExecutableMember.from(executable, substitution);
+        executable = SubstitutedExecutableElementImpl.from(
+          executable,
+          substitution,
+        );
         implemented[entry.key] = executable;
       }
 
@@ -530,7 +539,10 @@ class InheritanceManager3 {
       var mixinConflicts = <Conflict>[];
       for (var entry in mixinInterface.map.entries) {
         var name = entry.key;
-        var candidate = ExecutableMember.from(entry.value, substitution);
+        var candidate = SubstitutedExecutableElementImpl.from(
+          entry.value,
+          substitution,
+        );
 
         var currentList = namedCandidates[name];
         if (currentList == null) {
@@ -694,7 +706,10 @@ class InheritanceManager3 {
       var substitution = Substitution.fromInterfaceType(interface);
       for (var entry in getInterface(interface.element).map.entries) {
         var name = entry.key;
-        var executable = ExecutableMember.from(entry.value, substitution);
+        var executable = SubstitutedExecutableElementImpl.from(
+          entry.value,
+          substitution,
+        );
         if (executable.isExtensionTypeMember) {
           (extensionCandidates[name] ??= _ExtensionTypeCandidates(name)).add(
             executable,