Elements. Make ConstructorElementImpl implement ConstantEvaluationTarget, and ConstructorElementMixin2 not.

Change-Id: I1359d86a4c6b6ad0c2c31c30677703f9e0315773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/437888
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -86,10 +86,6 @@ class ConstantEvaluationEngine {
       constant = element.declaration as ConstantEvaluationTarget;
     }
 
-    if (constant case ConstructorElementMixin2 constructor) {
-      constant = constructor.baseElement;
-    }
-
     var library = constant.library as LibraryElementImpl;
     if (constant is FormalParameterElementImpl) {
       var defaultValue = constant.constantInitializer2?.expression;

pkg/analyzer/lib/src/dart/element/element.dart

@@ -749,7 +749,7 @@ class ConstructorElementImpl extends ExecutableElementImpl
         FragmentedElementMixin<ConstructorFragmentImpl>,
         ConstructorElementMixin2,
         _HasSinceSdkVersionMixin
-    implements ConstructorElement {
+    implements ConstantEvaluationTarget, ConstructorElement {
   @override
   final Reference reference;
 
@@ -931,10 +931,7 @@ class ConstructorElementImpl extends ExecutableElementImpl
 
 /// Common implementation for methods defined in [ConstructorElement].
 mixin ConstructorElementMixin2
-    implements
-        ConstantEvaluationTarget,
-        ExecutableElement2OrMember,
-        ConstructorElement {
+    implements ExecutableElement2OrMember, ConstructorElement {
   @override
   ConstructorElementImpl get baseElement;
 

pkg/analyzer/lib/src/dart/element/member.dart

@@ -64,9 +64,6 @@ class ConstructorMember extends ExecutableMember
   @override
   bool get isConst => declaration.isConst;
 
-  @override
-  bool get isConstantEvaluated => declaration.isConstantEvaluated;
-
   @override
   bool get isDefaultConstructor => baseElement.isConst;