lint rules: Move the last of the unnecessary_parenthesis tests

Change-Id: I0f26dffc3a49b10542fdbbf444572810998ff552
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393360
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: srawlins

pkg/linter/test/rules/unnecessary_parenthesis_test.dart

@@ -81,6 +81,23 @@ void f(int a, int b) {
 ''');
   }
 
+  test_binaryExpressionInside_assignment() async {
+    await assertNoDiagnostics(r'''
+void f(bool x) {
+  x = (1 == 1);
+}
+''');
+  }
+
+  test_binaryExpressionInside_binaryExpression() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  (1 == 1) || "".isEmpty;
+
+}
+''');
+  }
+
   test_binaryExpressionInside_constructorFieldInitializer() async {
     await assertDiagnostics(r'''
 class C {
@@ -146,6 +163,39 @@ bool f() {
     ]);
   }
 
+  test_binaryExpressionInside_switchStatementVariable() async {
+    await assertDiagnostics(r'''
+void f() {
+  switch ((5 == 6)) {
+    case true:
+      return;
+    default:
+      return;
+  }
+}
+''', [
+      lint(21, 8),
+    ]);
+  }
+
+  test_binaryExpressionInside_variableDeclarationInitializer() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  var x = (1 == 1);
+}
+''');
+  }
+
+  test_binaryExpressionInside_whileCondition() async {
+    await assertDiagnostics(r'''
+void f() {
+  while ((1 == 1)) {}
+}
+''', [
+      lint(20, 8),
+    ]);
+  }
+
   test_binaryOperationInside_binaryOperation() async {
     await assertNoDiagnostics(r'''
 void f(bool a, bool b) {
@@ -206,12 +256,30 @@ void f(int p) {
     ]);
   }
 
+  test_conditionalExpressionInside_argumentList() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  'a'.substring((1 == 1 ? 2 : 3), 1);
+}
+''');
+  }
+
   test_conditionalExpressionInside_expressionBody() async {
     await assertNoDiagnostics(r'''
 int f() => (1 == 1 ? 2 : 3);
 ''');
   }
 
+  test_conditionalExpressionInside_ifCondition() async {
+    await assertDiagnostics(r'''
+void f() {
+  if ((1 == 1 ? true : false)) {}
+}
+''', [
+      lint(17, 23),
+    ]);
+  }
+
   test_conditionalExpressionInside_listLiteral() async {
     await assertNoDiagnostics(r'''
 void f() {
@@ -238,6 +306,14 @@ void f(bool b) {
 ''');
   }
 
+  test_conditionalExpressionInside_variableDeclarationInitiailizer() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  var x = (1 == 1 ? 2 : 3);
+}
+''');
+  }
+
   /// https://github.com/dart-lang/linter/issues/4060
   test_constantPattern() async {
     await assertNoDiagnostics(r'''
@@ -441,6 +517,16 @@ void f() {
 ''');
   }
 
+  test_intLiteralInside_recordLiteral() async {
+    await assertDiagnostics(r'''
+void f() {
+  var x = (1, (2));
+}
+''', [
+      lint(25, 3),
+    ]);
+  }
+
   test_listLiteral() async {
     await assertDiagnostics(r'''
 final items = [1, (DateTime.now())];
@@ -465,6 +551,22 @@ void f(int? a) {
 ''');
   }
 
+  test_nullAwareIndexExpressionInside_conditionExpression() async {
+    await assertNoDiagnostics(r'''
+void f(List<int>? a, bool b) {
+  var x = b ? (a?[7]) : 7;
+}
+''');
+  }
+
+  test_nullAwareIndexExpressionInside_mapLiteralKey() async {
+    await assertNoDiagnostics(r'''
+void f(List<int>? a) {
+  var x = {(a?[7]): 7};
+}
+''');
+  }
+
   test_nullAwareIndexExpressionInside_postfixExpression() async {
     await assertNoDiagnostics(r'''
 void f(List<int?>? a) {
@@ -561,6 +663,16 @@ abstract class A {
 ''');
   }
 
+  test_prefixedIdentifierInside_recordLiteral() async {
+    await assertDiagnostics(r'''
+void f() {
+  var x = ((''.isEmpty), 2);
+}
+''', [
+      lint(22, 12),
+    ]);
+  }
+
   test_prefixedIdentifierInside_targetOfMethodCall() async {
     await assertDiagnostics(r'''
 void f() {
@@ -589,6 +701,16 @@ void f(bool b) {
 ''');
   }
 
+  test_propertyAccessInside_prefixExpression() async {
+    await assertDiagnostics(r'''
+void f() {
+  !([].isEmpty);
+}
+''', [
+      lint(14, 12),
+    ]);
+  }
+
   test_propertyAccessInside_recordLiteral() async {
     await assertDiagnostics(r'''
 Record f() {
@@ -845,6 +967,16 @@ void f() {
     ]);
   }
 
+  test_stringLiteralInside_variableDeclarationInitializer() async {
+    await assertDiagnostics(r'''
+void f() {
+  var x = ('');
+}
+''', [
+      lint(21, 4),
+    ]);
+  }
+
   test_switchExpressionInside_argument() async {
     await assertDiagnostics(r'''
 void f(Object? x) {