Skip to content

Commit 024144e

Browse files
stereotype441Commit Queue
authored andcommitted
[analyzer] Remove corresponding{Getter,Setter} from fragment APIs.
It doesn't make sense to ask a getter/setter fragment what its corresponding setter/getter is. It only makes sense to ask that question of a getter/setter element. Change-Id: Ie4cca352db8943f697b306e1d26035f5abac7722 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412180 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent 36c57a4 commit 024144e

File tree

3 files changed

+2
-18
lines changed

3 files changed

+2
-18
lines changed

pkg/analyzer/api.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3872,7 +3872,6 @@ package:analyzer/dart/element/element2.dart:
38723872
fragments (getter: List<GetterFragment>)
38733873
GetterFragment (class extends Object implements PropertyAccessorFragment):
38743874
new (constructor: GetterFragment Function())
3875-
correspondingSetter2 (getter: SetterFragment?)
38763875
element (getter: GetterElement)
38773876
nextFragment (getter: GetterFragment?)
38783877
previousFragment (getter: GetterFragment?)
@@ -4205,7 +4204,6 @@ package:analyzer/dart/element/element2.dart:
42054204
fragments (getter: List<SetterFragment>)
42064205
SetterFragment (class extends Object implements PropertyAccessorFragment):
42074206
new (constructor: SetterFragment Function())
4208-
correspondingGetter2 (getter: GetterFragment?)
42094207
element (getter: SetterElement)
42104208
nextFragment (getter: SetterFragment?)
42114209
previousFragment (getter: SetterFragment?)

pkg/analyzer/lib/dart/element/element2.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1177,10 +1177,6 @@ abstract class GetterElement implements PropertyAccessorElement2 {
11771177
///
11781178
/// Clients may not extend, implement or mix-in this class.
11791179
abstract class GetterFragment implements PropertyAccessorFragment {
1180-
/// The setter that corresponds to (has the same name as) this getter, or
1181-
/// `null` if there is no corresponding setter.
1182-
SetterFragment? get correspondingSetter2;
1183-
11841180
@override
11851181
GetterElement get element;
11861182

@@ -2490,10 +2486,6 @@ abstract class SetterElement implements PropertyAccessorElement2 {
24902486
///
24912487
/// Clients may not extend, implement or mix-in this class.
24922488
abstract class SetterFragment implements PropertyAccessorFragment {
2493-
/// The getter that corresponds to (has the same name as) this setter, or
2494-
/// `null` if there is no corresponding getter.
2495-
GetterFragment? get correspondingGetter2;
2496-
24972489
@override
24982490
SetterElement get element;
24992491

pkg/analyzer/lib/src/dart/element/element.dart

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5633,7 +5633,7 @@ class GetterElementImpl extends PropertyAccessorElementImpl2
56335633

56345634
@override
56355635
SetterElement? get correspondingSetter2 =>
5636-
firstFragment.correspondingSetter2?.element;
5636+
firstFragment.variable2?.setter?.element;
56375637

56385638
@override
56395639
List<GetterFragmentImpl> get fragments {
@@ -5699,9 +5699,6 @@ class GetterFragmentImpl extends PropertyAccessorElementImpl
56995699
@override
57005700
PropertyAccessorElement? get correspondingSetter => variable2?.setter;
57015701

5702-
@override
5703-
SetterFragment? get correspondingSetter2 => variable2?.setter;
5704-
57055702
@override
57065703
GetterElementImpl get element {
57075704
if (_element != null) {
@@ -10714,7 +10711,7 @@ class SetterElementImpl extends PropertyAccessorElementImpl2
1071410711

1071510712
@override
1071610713
GetterElement? get correspondingGetter2 =>
10717-
firstFragment.correspondingGetter2?.element;
10714+
firstFragment.variable2?.getter?.element;
1071810715

1071910716
@override
1072010717
Element2 get enclosingElement2 => firstFragment.enclosingFragment.element;
@@ -10788,9 +10785,6 @@ class SetterFragmentImpl extends PropertyAccessorElementImpl
1078810785
@override
1078910786
PropertyAccessorElement? get correspondingGetter => variable2?.getter;
1079010787

10791-
@override
10792-
GetterFragment? get correspondingGetter2 => variable2?.getter;
10793-
1079410788
@override
1079510789
PropertyAccessorElement? get correspondingSetter => null;
1079610790

0 commit comments

Comments
 (0)