Elements. Store isPromotable for synthetic fields.

Change-Id: I1f6dd03e3d7436f18c3f986c5208488d65a20fbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395403
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -99,7 +99,7 @@ import 'package:meta/meta.dart';
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 422;
+  static const int DATA_VERSION = 423;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -1603,15 +1603,17 @@ class LibraryReader {
           variables2!.add(variableElement);
         }
       } else {
+        var isPromotable = _reader.readBool();
         if (existing is FieldElementImpl && canUseExisting(existing)) {
           propertyFragment = existing;
         } else {
           propertyFragment = FieldElementImpl(name, -1)
             ..enclosingElement3 = enclosingElement
             ..reference = propertyFragmentReference
+            ..name2 = accessor.name2
             ..isStatic = accessor.isStatic
             ..isSynthetic = true
-            ..name2 = accessor.name2;
+            ..isPromotable = isPromotable;
           propertyFragmentReference.element ??= propertyFragment;
           propertyFragments.add(propertyFragment);
         }

pkg/analyzer/lib/src/summary2/bundle_writer.dart

@@ -634,6 +634,11 @@ class BundleWriter {
             ?.element
             .reference,
       );
+      switch (variableFragment) {
+        case FieldElementImpl fieldFragment:
+          var field = fieldFragment.element;
+          _sink.writeBool(field.isPromotable);
+      }
     }
   }
 

pkg/analyzer/test/src/summary/elements/class_test.dart

@@ -12694,6 +12694,80 @@ library
 ''');
   }
 
+  test_class_field_isPromotable_abstractGetter() async {
+    var library = await buildLibrary(r'''
+abstract class A {
+  int? get _foo;
+}
+''');
+
+    checkElementText(library, r'''
+library
+  reference: <testLibrary>
+  definingUnit: <testLibraryFragment>
+  units
+    <testLibraryFragment>
+      enclosingElement3: <null>
+      classes
+        abstract class A @15
+          reference: <testLibraryFragment>::@class::A
+          enclosingElement3: <testLibraryFragment>
+          fields
+            synthetic promotable _foo @-1
+              reference: <testLibraryFragment>::@class::A::@field::_foo
+              enclosingElement3: <testLibraryFragment>::@class::A
+              type: int?
+          constructors
+            synthetic @-1
+              reference: <testLibraryFragment>::@class::A::@constructor::new
+              enclosingElement3: <testLibraryFragment>::@class::A
+          accessors
+            abstract get _foo @30
+              reference: <testLibraryFragment>::@class::A::@getter::_foo
+              enclosingElement3: <testLibraryFragment>::@class::A
+              returnType: int?
+----------------------------------------
+library
+  reference: <testLibrary>
+  fragments
+    <testLibraryFragment>
+      element: <testLibrary>
+      classes
+        class A @15
+          reference: <testLibraryFragment>::@class::A
+          element: <testLibrary>::@class::A
+          fields
+            promotable _foo
+              reference: <testLibraryFragment>::@class::A::@field::_foo
+              element: <testLibraryFragment>::@class::A::@field::_foo#element
+              getter2: <testLibraryFragment>::@class::A::@getter::_foo
+          constructors
+            synthetic new
+              reference: <testLibraryFragment>::@class::A::@constructor::new
+              element: <testLibraryFragment>::@class::A::@constructor::new#element
+              typeName: A
+          getters
+            get _foo @30
+              reference: <testLibraryFragment>::@class::A::@getter::_foo
+              element: <testLibraryFragment>::@class::A::@getter::_foo#element
+  classes
+    abstract class A
+      reference: <testLibrary>::@class::A
+      firstFragment: <testLibraryFragment>::@class::A
+      fields
+        synthetic _foo
+          firstFragment: <testLibraryFragment>::@class::A::@field::_foo
+          type: int?
+          getter: <testLibraryFragment>::@class::A::@getter::_foo#element
+      constructors
+        synthetic new
+          firstFragment: <testLibraryFragment>::@class::A::@constructor::new
+      getters
+        abstract get _foo
+          firstFragment: <testLibraryFragment>::@class::A::@getter::_foo
+''');
+  }
+
   test_class_field_isPromotable_hasGetter() async {
     var library = await buildLibrary(r'''
 class A {