Skip to content

Commit 031c28f

Browse files
alexmarkovCommit Queue
authored andcommitted
[gardening] Do not pass --gc_at_throw to isolate stress testing
This flag makes stress testing shards extremely slow (50+m while usually they take <10m) and sometimes causes timeouts. Change-Id: Icc828d72ebf8d14b4d3a1f76deeb9de61c6b4f9e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/440960 Auto-Submit: Alexander Markov <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
1 parent 37b06b4 commit 031c28f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

runtime/tests/concurrency/run_stress_test_shards.dart

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@ void writeUnexpectedCrashesFile(List<PotentialCrash> crashes) {
144144
File(unexpectedCrashesFile).writeAsStringSync(buffer.toString());
145145
}
146146

147+
Iterable<String> filterSlowFlags(Iterable<String> flags) =>
148+
flags.where((flag) => !flag.startsWith('--gc_at_throw'));
149+
147150
const int tsanShards = 64;
148151

149152
late final List<TestRunner> configurations;
@@ -176,12 +179,12 @@ main(List<String> arguments) async {
176179
configurations = <TestRunner>[
177180
JitTestRunner('out/Debug$arch', [
178181
'--disable-dart-dev',
179-
...someJitRuntimeFlags(),
182+
...filterSlowFlags(someJitRuntimeFlags()),
180183
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
181184
]),
182185
JitTestRunner('out/Release$arch', [
183186
'--disable-dart-dev',
184-
...someJitRuntimeFlags(),
187+
...filterSlowFlags(someJitRuntimeFlags()),
185188
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
186189
]),
187190
AotTestRunner(
@@ -190,23 +193,22 @@ main(List<String> arguments) async {
190193
...someGenSnapshotFlags(),
191194
'runtime/tests/concurrency/generated_stress_test.dart.aot.dill',
192195
],
193-
[...someAotRuntimeFlags()],
196+
[...filterSlowFlags(someAotRuntimeFlags())],
194197
),
195198
AotTestRunner(
196199
'out/Release$arch',
197200
[
198201
...someGenSnapshotFlags(),
199202
'runtime/tests/concurrency/generated_stress_test.dart.aot.dill',
200203
],
201-
[...someAotRuntimeFlags()],
204+
[...filterSlowFlags(someAotRuntimeFlags())],
202205
),
203206
// TSAN last so the other steps are evenly distributed.
204207
for (int i = 0; i < tsanShards; ++i)
205208
JitTestRunner('out/ReleaseTSAN$arch', [
206209
'--disable-dart-dev',
207-
...someJitRuntimeFlags(),
210+
...filterSlowFlags(someJitRuntimeFlags()),
208211
'--no-profiler', // TODO(https://github.com/dart-lang/sdk/issues/60804, https://github.com/dart-lang/sdk/issues/60805)
209-
'--no-gc_at_throw', // Too slow under TSAN
210212
'-Drepeat=4',
211213
'-Dshard=$i',
212214
'-Dshards=$tsanShards',

0 commit comments

Comments
 (0)