Skip to content

Commit 0476f21

Browse files
DanTupCommit Queue
authored andcommitted
[analysis_server] Mark editableArguments / editArgument as not-experimental
This should not be landed until after flutter/devtools#8990 lands and is included in the version of DevTools in the Dart SDK. Fixes #55629 Change-Id: I19a72ef0e3680aa620d47f8f9556e38b90a98aa4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414060 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Elliott Brooks <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
1 parent 0bed1ac commit 0476f21

File tree

2 files changed

+21
-4
lines changed

2 files changed

+21
-4
lines changed

pkg/analysis_server/lib/src/lsp/constants.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,12 @@ abstract final class CustomMethods {
157157
/// Method for requesting the set of editable arguments at a location in a
158158
/// document.
159159
static const dartTextDocumentEditableArguments = Method(
160-
'experimental/dart/textDocument/editableArguments',
160+
'dart/textDocument/editableArguments',
161161
);
162162

163163
/// Method for adding/editing an argument at a location in a document.
164164
static const dartTextDocumentEditArgument = Method(
165-
'experimental/dart/textDocument/editArgument',
165+
'dart/textDocument/editArgument',
166166
);
167167

168168
// TODO(dantup): Remove custom AnalyzerStatus status method soon as no clients

pkg/analysis_server/tool/lsp_spec/README.md

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,13 +285,30 @@ Params: `{ uri: Uri }`
285285

286286
Notifies the client that the content in the virtual file with `uri` may have changed (for example because a macro executed and regenerated its content).
287287

288-
### dart/connectToDtd Method (Experimental)
288+
### dart/connectToDtd Method
289289

290290
Direction: Client -> Server
291291
Params: `{ uri: Uri }`
292292
Returns: `null`
293293

294-
Provides the URI of a Dart Tooling Daemon server to allow the LSP server to connect and provide access to a subset of LSP functionality to DTD clients. This support is still a work in progress and should not be used outside of development (yet).
294+
Provides the URI of a Dart Tooling Daemon server to allow the LSP server to connect and provide access to a subset of LSP functionality to DTD clients. This method can only be called by the tool that owns the analysis server process (via stdin/stdout) and not through DTD.
295+
296+
### dart/textDocument/editableArguments Method
297+
298+
Direction: Client -> Server
299+
Params: `TextDocumentPositionParams`
300+
Returns: `EditableArguments`
301+
302+
Returns the list of editable arguments at a position within the current document. This information can be used to update arguments in the document by using the `dart/textDocument/editArgument` request.
303+
304+
### dart/textDocument/editArgument Method
305+
306+
Direction: Client -> Server
307+
Params: `EditArgumentParams`
308+
Returns: `Null`
309+
310+
Instructs the editor to edit the value of an argument (that was returned from a `dart/textDocument/editableArguments` request).
311+
295312

296313
## Client Commands
297314

0 commit comments

Comments
 (0)