[analyzer] Generate diagnostic codes into part files.

Previously, diagnostic codes were generated into libraries. This led
to a proliferation of imports of those generated libraries throughout
the analyzer and analysis server codebases, since the analysis server
didn't know that it should suggest adding imports of the correspinding
non-generated libraries instead.

I tried to fix that problem by marking each generated diagnostic code
library as deprecated, and ignoring the deprecation warning at the
site where the corresponding non-generated file imports it. But this
led to a different problem: it prevented code completion from
suggesting elements that came from the generated libraries. In my work
toward replacing the analyzer's error reporting API with a more
literate API (e.g. `reportError(errorCode.withArguments(...).at(...))`),
I've discovered that the lack of code completion makes the more
literate API much harder to use.

This CL changes the code generator so that diagnostic codes are
generated into part files. This neatly prevents unintentional imports
of the generated files without having to do any tricks with
deprecation.

A side benefit of this change is that the code generators no longer
need complex logic to determine which `import` directives to generate,
since the import directives live in the non-code-generated parent
library.

Note that in the past, the analyzer code base has heavily discouraged
the use of part files. I think they are justified in this case,
because the files are generated; if it were not for the desire to code
generate these files, we would fold them straight into the libraries
they are parts of.

Change-Id: I6a6a6964a375ee81f9580b354766bd041c83b3cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445480
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Nate Biggs <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/lib/src/scanner/errors.dart

@@ -2,16 +2,13 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore: deprecated_member_use_from_same_package
-import 'package:_fe_analyzer_shared/src/scanner/errors.g.dart';
-
+import '../base/errors.dart';
 import '../messages/codes.dart';
 import 'error_token.dart';
 import 'token.dart' show Token, TokenType;
 import 'token_constants.dart';
 
-// ignore: deprecated_member_use_from_same_package
-export 'package:_fe_analyzer_shared/src/scanner/errors.g.dart';
+part 'errors.g.dart';
 
 /**
  *  Translates the given error [token] into an analyzer error and reports it

pkg/_fe_analyzer_shared/lib/src/scanner/errors.g.dart

@@ -14,17 +14,7 @@
 // Generated comments don't quite align with flutter style.
 // ignore_for_file: flutter_style_todos
 
-/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
-/// @docImport 'package:analyzer/src/error/inference_error.dart';
-@Deprecated(
-  // This library is deprecated to prevent it from being accidentally imported
-  // It should only be imported by the corresponding non-code-generated library
-  // (which suppresses the deprecation warning using an "ignore" comment).
-  'Use package:_fe_analyzer_shared/src/scanner/errors.dart instead',
-)
-library;
-
-import "package:_fe_analyzer_shared/src/base/errors.dart";
+part of "package:_fe_analyzer_shared/src/scanner/errors.dart";
 
 class ScannerErrorCode extends DiagnosticCode {
   /// Parameters:

pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_error_code.dart

@@ -2,6 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore: deprecated_member_use_from_same_package
-export 'package:analysis_server/src/services/correction/fix/data_driven/transform_set_error_code.g.dart'
-    show TransformSetErrorCode;
+import 'package:analyzer/error/error.dart';
+
+part 'package:analysis_server/src/services/correction/fix/data_driven/transform_set_error_code.g.dart';

pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_error_code.g.dart

@@ -15,17 +15,7 @@
 // Generated comments don't quite align with flutter style.
 // ignore_for_file: flutter_style_todos
 
-/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
-/// @docImport 'package:analyzer/src/error/inference_error.dart';
-@Deprecated(
-  // This library is deprecated to prevent it from being accidentally imported
-  // It should only be imported by the corresponding non-code-generated library
-  // (which suppresses the deprecation warning using an "ignore" comment).
-  'Use package:analysis_server/src/services/correction/fix/data_driven/transform_set_error_code.dart instead',
-)
-library;
-
-import "package:_fe_analyzer_shared/src/base/errors.dart";
+part of "package:analysis_server/src/services/correction/fix/data_driven/transform_set_error_code.dart";
 
 /// An error code representing a problem in a file containing an encoding of a
 /// transform set.

pkg/analyzer/lib/src/analysis_options/error/option_codes.dart

@@ -2,5 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore: deprecated_member_use_from_same_package
-export 'package:analyzer/src/analysis_options/error/option_codes.g.dart';
+import 'package:analyzer/error/error.dart';
+
+part 'package:analyzer/src/analysis_options/error/option_codes.g.dart';

pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart

@@ -14,17 +14,7 @@
 // Generated comments don't quite align with flutter style.
 // ignore_for_file: flutter_style_todos
 
-/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
-/// @docImport 'package:analyzer/src/error/inference_error.dart';
-@Deprecated(
-  // This library is deprecated to prevent it from being accidentally imported
-  // It should only be imported by the corresponding non-code-generated library
-  // (which suppresses the deprecation warning using an "ignore" comment).
-  'Use package:analyzer/src/analysis_options/error/option_codes.dart instead',
-)
-library;
-
-import "package:_fe_analyzer_shared/src/base/errors.dart";
+part of "package:analyzer/src/analysis_options/error/option_codes.dart";
 
 class AnalysisOptionsErrorCode extends DiagnosticCode {
   /// An error code indicating that there is a syntactic error in the included

pkg/analyzer/lib/src/dart/error/ffi_code.dart

@@ -2,5 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore: deprecated_member_use_from_same_package
-export 'package:analyzer/src/dart/error/ffi_code.g.dart';
+import 'package:analyzer/error/error.dart';
+
+part 'package:analyzer/src/dart/error/ffi_code.g.dart';

pkg/analyzer/lib/src/dart/error/ffi_code.g.dart

@@ -14,17 +14,7 @@
 // Generated comments don't quite align with flutter style.
 // ignore_for_file: flutter_style_todos
 
-/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
-/// @docImport 'package:analyzer/src/error/inference_error.dart';
-@Deprecated(
-  // This library is deprecated to prevent it from being accidentally imported
-  // It should only be imported by the corresponding non-code-generated library
-  // (which suppresses the deprecation warning using an "ignore" comment).
-  'Use package:analyzer/src/dart/error/ffi_code.dart instead',
-)
-library;
-
-import "package:_fe_analyzer_shared/src/base/errors.dart";
+part of "package:analyzer/src/dart/error/ffi_code.dart";
 
 class FfiCode extends DiagnosticCode {
   /// No parameters.

pkg/analyzer/lib/src/dart/error/hint_codes.dart

@@ -2,5 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore: deprecated_member_use_from_same_package
-export 'package:analyzer/src/dart/error/hint_codes.g.dart';
+import 'package:analyzer/error/error.dart';
+
+part 'package:analyzer/src/dart/error/hint_codes.g.dart';

pkg/analyzer/lib/src/dart/error/hint_codes.g.dart

@@ -14,17 +14,7 @@
 // Generated comments don't quite align with flutter style.
 // ignore_for_file: flutter_style_todos
 
-/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
-/// @docImport 'package:analyzer/src/error/inference_error.dart';
-@Deprecated(
-  // This library is deprecated to prevent it from being accidentally imported
-  // It should only be imported by the corresponding non-code-generated library
-  // (which suppresses the deprecation warning using an "ignore" comment).
-  'Use package:analyzer/src/dart/error/hint_codes.dart instead',
-)
-library;
-
-import "package:_fe_analyzer_shared/src/base/errors.dart";
+part of "package:analyzer/src/dart/error/hint_codes.dart";
 
 class HintCode extends DiagnosticCode {
   /// Note: Since this diagnostic is only produced in pre-3.0 code, we do not