Skip to content

Commit 064339a

Browse files
fshcheglovCommit Queue
authored andcommitted
Remove the skip annotation from several tests that used to cause errors but don't anymore.
Update comment in `element_builder` to have simpler phrasing. Rename the argument in `addTypeParameter` to be more consistent. Change-Id: Ifdb1d63e5c1c4e06fddae51e0149748b14affde5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448663 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent 10bc588 commit 064339a

File tree

3 files changed

+325
-832
lines changed

3 files changed

+325
-832
lines changed

pkg/analyzer/lib/src/dart/element/element.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4710,9 +4710,9 @@ abstract class InstanceFragmentImpl extends FragmentImpl
47104710
fragment.enclosingFragment = this;
47114711
}
47124712

4713-
void addTypeParameter(TypeParameterFragmentImpl typeParameter) {
4714-
_typeParameters.add(typeParameter);
4715-
typeParameter.enclosingFragment = this;
4713+
void addTypeParameter(TypeParameterFragmentImpl fragment) {
4714+
_typeParameters.add(fragment);
4715+
fragment.enclosingFragment = this;
47164716
}
47174717
}
47184718

pkg/analyzer/lib/src/summary2/element_builder.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ class ElementBuilder {
201201
fragment.typeParameters.length = lastTypeParameterFragments.length;
202202
}
203203

204-
// Synthesize missing type parameters.
204+
// Add missing type parameters.
205205
if (lastTypeParameterFragments.length > fragment.typeParameters.length) {
206206
for (
207207
var i = fragment.typeParameters.length;

0 commit comments

Comments
 (0)